josch/img2pdf
3
6
Fork 10
Code Issues 22 Pull requests 5 Projects Releases 3 Wiki Activity

support new pikepdf.Page object when making indirect objects (closes: #132)

Browse source
This commit is contained in:
Johannes Schauer Marin Rodrigues 2022-04-07 21:55:45 +02:00
parent 3b117e674b
commit 1d52530229
Signed by: josch
GPG key ID: F2CBA5C78FBD83E1
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/img2pdf.py
View file

@ -1106,9 +1106,17 @@ class pdfdoc(object):
[initial_page, PdfName.XYZ, NullObject, NullObject, 0] [initial_page, PdfName.XYZ, NullObject, NullObject, 0]
) )
# the /OpenAction array must contain the page as an indirect object # The /OpenAction array must contain the page as an indirect object.
# This changed some time after 4.2.0 and on or before 5.0.0 and current
# versions require to use .obj or otherwise we get:
# TypeError: Can't convert ObjectHelper (or subclass) to Object
# implicitly. Use .obj to get access the underlying object.
# See https://github.com/pikepdf/pikepdf/issues/313 for details.
if self.engine == Engine.pikepdf: if self.engine == Engine.pikepdf:
initial_page = self.writer.make_indirect(initial_page) if isinstance(initial_page, pikepdf.Page):
initial_page = self.writer.make_indirect(initial_page.obj)
else:
initial_page = self.writer.make_indirect(initial_page)
if self.magnification == Magnification.fit: if self.magnification == Magnification.fit:
catalog[PdfName.OpenAction] = PdfArray([initial_page, PdfName.Fit]) catalog[PdfName.OpenAction] = PdfArray([initial_page, PdfName.Fit])