Remove pdfrw from src/img2pdf_test.py #108

New issue

Closed

opened 2021-07-04 11:48:51 +00:00 by gms · 4 comments

gms commented

2021-07-04 11:48:51 +00:00

As far as I understood it, pdfrw is pretty much dead and img2pdf switched to pikepdf as its primary pdf engine.

Thus, it seems like removing pdfrw support for the test suite would be appropriate.

Currently, I need to disable them in my spec file since I don't want to depend on pdfrw, like this:

sed -i 's/, "pdfrw"\])/])/' src/img2pdf_test.py

As far as I understood it, pdfrw is pretty much dead and img2pdf switched to pikepdf as its primary pdf engine. Thus, it seems like removing pdfrw support for the test suite would be appropriate. Currently, I need to disable them in my spec file since I don't want to depend on pdfrw, like this: ``` sed -i 's/, "pdfrw"\])/])/' src/img2pdf_test.py ```

mara0004 referenced this issue

2021-08-02 17:43:07 +00:00

Add PyMuPDF engine #113

josch commented

2021-10-03 13:16:02 +00:00

Owner

Agreed. pdfrw should go.

Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora?

Also, do you currently build img2pdf with some patches applied? Maybe I can apply those, so that you can drop them in the next release.

Thanks!

Agreed. pdfrw should go. Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora? Also, do you currently build img2pdf with some patches applied? Maybe I can apply those, so that you can drop them in the next release. Thanks!

josch referenced this issue from a commit

2021-10-09 13:30:08 +00:00

remove pdfrw from tests (closes: #108)

josch closed this issue

2021-10-09 13:30:13 +00:00

gms commented

2021-10-16 10:58:28 +00:00

Author

Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora?

Right now even Rawhide is still on ImageMagick 6.9.

So probably yes.

> Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora? Right now even Rawhide is still on ImageMagick 6.9. So probably yes.

josch commented

2021-10-16 11:44:15 +00:00

Owner

Debian unstable as well as experimental are also still on 6.9. I tested the latest release so that it works with imagemagick 6.9.11.60 as well as with 7.1.0.5.

Can you confirm that the tests pass on Fedora as well?

Debian unstable as well as experimental are also still on 6.9. I tested the latest release so that it works with imagemagick 6.9.11.60 as well as with 7.1.0.5. Can you confirm that the tests pass on Fedora as well?

gms commented

2021-10-17 20:59:01 +00:00

Author

Can you confirm that the tests pass on Fedora as well?

Yes, I can. I've just removed the workarounds (using 0.4.2) and the build succeeds:

https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2894523/

Looks like #85 can be closed then, right?

> Can you confirm that the tests pass on Fedora as well? Yes, I can. I've just removed the workarounds (using 0.4.2) and the build succeeds: https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2894523/ Looks like #85 can be closed then, right?