As far as I understood it, pdfrw is pretty much dead and img2pdf switched to pikepdf as its primary pdf engine.
Thus, it seems like removing pdfrw support for the test suite would be appropriate.
Currently, I need to disable them in my spec file since I don't want to depend on pdfrw, like this:
sed -i 's/, "pdfrw"\])/])/' src/img2pdf_test.py
As far as I understood it, pdfrw is pretty much dead and img2pdf switched to pikepdf as its primary pdf engine.
Thus, it seems like removing pdfrw support for the test suite would be appropriate.
Currently, I need to disable them in my spec file since I don't want to depend on pdfrw, like this:
```
sed -i 's/, "pdfrw"\])/])/' src/img2pdf_test.py
```
Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora?
Also, do you currently build img2pdf with some patches applied? Maybe I can apply those, so that you can drop them in the next release.
Thanks!
Agreed. pdfrw should go.
Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora?
Also, do you currently build img2pdf with some patches applied? Maybe I can apply those, so that you can drop them in the next release.
Thanks!
Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora?
Right now even Rawhide is still on ImageMagick 6.9.
So probably yes.
> Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora?
Right now even Rawhide is still on ImageMagick 6.9.
So probably yes.
Debian unstable as well as experimental are also still on 6.9. I tested the latest release so that it works with imagemagick 6.9.11.60 as well as with 7.1.0.5.
Can you confirm that the tests pass on Fedora as well?
Debian unstable as well as experimental are also still on 6.9. I tested the latest release so that it works with imagemagick 6.9.11.60 as well as with 7.1.0.5.
Can you confirm that the tests pass on Fedora as well?
> Can you confirm that the tests pass on Fedora as well?
Yes, I can. I've just removed the workarounds (using 0.4.2) and the build succeeds:
https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2894523/
Looks like #85 can be closed then, right?
As far as I understood it, pdfrw is pretty much dead and img2pdf switched to pikepdf as its primary pdf engine.
Thus, it seems like removing pdfrw support for the test suite would be appropriate.
Currently, I need to disable them in my spec file since I don't want to depend on pdfrw, like this:
Agreed. pdfrw should go.
Related to the tests, I have a local commit that switches the testsuite to imagemagick 7. Would that be a problem for Fedora?
Also, do you currently build img2pdf with some patches applied? Maybe I can apply those, so that you can drop them in the next release.
Thanks!
Right now even Rawhide is still on ImageMagick 6.9.
So probably yes.
Debian unstable as well as experimental are also still on 6.9. I tested the latest release so that it works with imagemagick 6.9.11.60 as well as with 7.1.0.5.
Can you confirm that the tests pass on Fedora as well?
Yes, I can. I've just removed the workarounds (using 0.4.2) and the build succeeds:
https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2894523/
Looks like #85 can be closed then, right?