josch/img2pdf
3
6
Fork 10
Code Issues 22 Pull requests 5 Projects Releases 3 Wiki Activity

0.5.0 test case failures on Fedora Rawhide #178

New issue
Open
opened 2023-10-29 14:34:51 +00:00 by gms · 7 comments
gms commented 2023-10-29 14:34:51 +00:00
Copy link

AFAICS, all the old test case failures are now gone, but there a few new cases that fail on Fedora Rawhide:

src/img2pdf_test.py:395: AssertionError
=========================== short test summary info ============================
FAILED src/img2pdf_test.py::test_jpg_2000_rgba8[internal] - subprocess.Called...
FAILED src/img2pdf_test.py::test_jpg_2000_rgba8[pikepdf] - subprocess.CalledP...
FAILED src/img2pdf_test.py::test_jpg_2000_rgba16[internal] - subprocess.Calle...
FAILED src/img2pdf_test.py::test_jpg_2000_rgba16[pikepdf] - subprocess.Called...
FAILED src/img2pdf_test.py::test_miff_cmyk8[internal] - AssertionError: asser...
FAILED src/img2pdf_test.py::test_miff_cmyk8[pikepdf] - AssertionError: assert...
FAILED src/img2pdf_test.py::test_miff_cmyk16[internal] - assert 6.35075 > 50
FAILED src/img2pdf_test.py::test_miff_cmyk16[pikepdf] - assert 6.35075 > 50
================== 8 failed, 335 passed, 8 skipped in 58.13s ===================

https://kojipkgs.fedoraproject.org//work/tasks/4018/108274018/build.log

The last two are related to this assertion:

            assert psnr != b"0"
            assert psnr != b"0 (0)"
            assert psnr_re.fullmatch(psnr) is not None, psnr
            psnr = psnr_re.fullmatch(psnr).group(1)
            psnr = float(psnr)
            assert psnr != 0  # or otherwise we would use the exact variant
>           assert psnr > 50
E           assert 6.35075 > 50
src/img2pdf_test.py:395: AssertionError

The two before:

            assert psnr != b"0"
>           assert psnr != b"0 (0)"
E           AssertionError: assert b'0 (0)' != b'0 (0)'
src/img2pdf_test.py:390: AssertionError

And the other all generate the same stderror output, similar to this instance:

>           raise CalledProcessError(retcode, cmd)
E           subprocess.CalledProcessError: Command '['compare', '-metric', 'AE', '-alpha', 'off', '/tmp/pytest-of-mockbuild/pytest-0/jpg_2000_rgba80/in.jp2', '/tmp/pytest-of-mockbuild/pytest-0/jpg_2000_rgba81/gs-1.png', 'null:']' returned non-zero exit status 1.
/usr/lib64/python3.12/subprocess.py:413: CalledProcessError
----------------------------- Captured stderr call -----------------------------
2190
AFAICS, all the old test case failures are now gone, but there a few new cases that fail on Fedora Rawhide: ``` src/img2pdf_test.py:395: AssertionError =========================== short test summary info ============================ FAILED src/img2pdf_test.py::test_jpg_2000_rgba8[internal] - subprocess.Called... FAILED src/img2pdf_test.py::test_jpg_2000_rgba8[pikepdf] - subprocess.CalledP... FAILED src/img2pdf_test.py::test_jpg_2000_rgba16[internal] - subprocess.Calle... FAILED src/img2pdf_test.py::test_jpg_2000_rgba16[pikepdf] - subprocess.Called... FAILED src/img2pdf_test.py::test_miff_cmyk8[internal] - AssertionError: asser... FAILED src/img2pdf_test.py::test_miff_cmyk8[pikepdf] - AssertionError: assert... FAILED src/img2pdf_test.py::test_miff_cmyk16[internal] - assert 6.35075 > 50 FAILED src/img2pdf_test.py::test_miff_cmyk16[pikepdf] - assert 6.35075 > 50 ================== 8 failed, 335 passed, 8 skipped in 58.13s =================== ``` https://kojipkgs.fedoraproject.org//work/tasks/4018/108274018/build.log The last two are related to this assertion: ``` assert psnr != b"0" assert psnr != b"0 (0)" assert psnr_re.fullmatch(psnr) is not None, psnr psnr = psnr_re.fullmatch(psnr).group(1) psnr = float(psnr) assert psnr != 0 # or otherwise we would use the exact variant > assert psnr > 50 E assert 6.35075 > 50 src/img2pdf_test.py:395: AssertionError ``` The two before: ``` assert psnr != b"0" > assert psnr != b"0 (0)" E AssertionError: assert b'0 (0)' != b'0 (0)' src/img2pdf_test.py:390: AssertionError ``` And the other all generate the same stderror output, similar to this instance: ``` > raise CalledProcessError(retcode, cmd) E subprocess.CalledProcessError: Command '['compare', '-metric', 'AE', '-alpha', 'off', '/tmp/pytest-of-mockbuild/pytest-0/jpg_2000_rgba80/in.jp2', '/tmp/pytest-of-mockbuild/pytest-0/jpg_2000_rgba81/gs-1.png', 'null:']' returned non-zero exit status 1. /usr/lib64/python3.12/subprocess.py:413: CalledProcessError ----------------------------- Captured stderr call ----------------------------- 2190 ```
josch commented 2023-10-29 18:00:18 +00:00
Owner
Copy link

I'm fighting with those as well as I'm now uploading the package to Debian. I'm currently using this patch:

https://salsa.debian.org/debian/img2pdf/-/blob/master/debian/patches/fix_tests.patch

But that didn't fix all yet. The remaining issues are regressions in imagemagick.

The img2pdf testcases really frustrate me as imagemagick behaviour changes pop up faster than I can bisect and report them in my free time...

I'm fighting with those as well as I'm now uploading the package to Debian. I'm currently using this patch: https://salsa.debian.org/debian/img2pdf/-/blob/master/debian/patches/fix_tests.patch But that didn't fix all yet. The remaining issues are regressions in imagemagick. The img2pdf testcases really frustrate me as imagemagick behaviour changes pop up faster than I can bisect and report them in my free time...
josch commented 2023-10-30 07:19:26 +00:00
Owner
Copy link

Filed here: https://github.com/ImageMagick/ImageMagick6/issues/285

Filed here: https://github.com/ImageMagick/ImageMagick6/issues/285
josch commented 2023-10-30 07:20:49 +00:00
Owner
Copy link

AFAICS, all the old test case failures are now gone

@gms could you close those issues that do not apply to Fedora anymore? Thanks!

> AFAICS, all the old test case failures are now gone @gms could you close those issues that do not apply to Fedora anymore? Thanks!
gms commented 2023-10-30 22:42:02 +00:00
Author
Copy link

AFAICS, all the old test case failures are now gone

@gms could you close those issues that do not apply to Fedora anymore? Thanks!

Sure, I've checked my notes and the old ones that affected Fedora were already closed (i.e. #152 and #161).

Yes, imagemagick is a moving target.

> > AFAICS, all the old test case failures are now gone > > @gms could you close those issues that do not apply to Fedora anymore? Thanks! Sure, I've checked my notes and the old ones that affected Fedora were already closed (i.e. #152 and #161). --- Yes, imagemagick is a moving target.
dotlambda commented 2023-11-01 15:46:18 +00:00
Copy link

On NixOS, applying 4a7dbda0f4/debian/patches/fix_tests.patch only leaves the two test_miff_cmyk16 test cases failing: https://github.com/NixOS/nixpkgs/pull/264119

On NixOS, applying https://salsa.debian.org/debian/img2pdf/-/blob/4a7dbda0f473f7c5ffcaaf68ea4ad3f435e0920d/debian/patches/fix_tests.patch only leaves the two `test_miff_cmyk16` test cases failing: https://github.com/NixOS/nixpkgs/pull/264119
josch commented 2023-11-01 16:30:37 +00:00
Owner
Copy link

@dotlambda thank you for testing! What version of imagemagick is that?

@dotlambda thank you for testing! What version of imagemagick is that?
mgorny commented 2024-06-02 14:49:37 +00:00
Copy link

For the record, test_miff_cmyk16 fails for me only when ImageMagick is built with --enable-hdri. So whatever the fix is, it will need to account for both variants.

For the record, `test_miff_cmyk16` fails for me only when ImageMagick is built with `--enable-hdri`. So whatever the fix is, it will need to account for both variants.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
0.5.1
0.5.0
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.3.6
0.3.5
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.2.4
0.2.3
0.2.2
0.2.1
0.1.5.dev
0.2.0
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
forwarded

not an img2pdf bug but in a dependency

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
forwarded
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: josch/img2pdf#178
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?