testsuite fails on Alpine s390x #62

New issue

Closed

opened 2021-04-25 19:58:28 +00:00 by josch · 0 comments

josch commented

2021-04-25 19:58:28 +00:00

Owner

By Tuan Hoang on 2019-05-18T20:33:33.712Z

Hello,

I'm seeing a couple of test failures on Alpine s390x. Would you mind having a look ?
The build log could be found at : https://build.alpinelinux.org/buildlogs/build-3-10-s390x/community/py-img2pdf/py-img2pdf-0.3.3-r1.log
Or back up at : http://tpaste.us/YM6r

Thanks,

By Tuan Hoang on 2019-05-18T20:36:07.440Z

And this is how Alpine buildscript looks like : https://git.alpinelinux.org/aports/tree/community/py-img2pdf/APKBUILD

img2pdf builds fine on Alpine on other little endian architectures like x86 and ppc64le.

By josch on 2019-05-18T21:22:38.860Z

The log looks more like a PIL/Pillow problem. Are you running PIL/Pillow test suites on Alpine under s390x?

By josch on 2019-05-18T21:44:49.495Z

I just ran the testsuite on s390x on Debian unstable where this worked fine so this seems to be Alpine specific and not a problem with s390x in general.

Could you maybe just try creating an empty image with your PIL implementatation on Alpine on s390x and run the tobytes() member function of the image? That is the one that seems to fail.

By Tuan Hoang on 2019-05-18T21:50:54.407Z

Looks like Alpine s390x does not run py-pillow testsuites : https://git.alpinelinux.org/aports/tree/main/py-pillow/APKBUILD#n17 (meaning make check is not run).

I disabled it a while ago: https://git.alpinelinux.org/aports/commit/main/py-pillow/APKBUILD?id=b65c2c0c9a5606eabd0361fa4e03c981bd0f17be.

It's a known from upstream pillow.

By Tuan Hoang on 2019-05-18T21:56:30.218Z

Could you maybe just try creating an empty image with your PIL implementatation on Alpine on s390x and run the tobytes() member function of the image? That is the one that seems to fail.

Would you mind explaining 'image' ?

By josch on 2019-05-18T22:08:58.783Z

This small snippet should throw an error on s390x alpine:

python3 -c 'from PIL import Image; img=Image.new("RGB", (10,10));img.tobytes()'

By Tuan Hoang on 2019-05-18T22:12:46.269Z

Yes.

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.7/site-packages/PIL/Image.py", line 756, in tobytes
    l, s, d = e.encode(bufsize)
MemoryError

In fact Fedora's pillow also skips test on s390x. Looking at Debian build and patches, I couldn't see how it does not face the test failures.

By josch on 2019-05-18T22:15:49.682Z

In that case, this is not an img2pdf problem.

If PIL doesn't work on Alpine on s390x, then img2pdf (which depends on PIL) cannot work on it either. And to fix it, you have to change PIL in Alpine and not img2pdf. Once your PIL is fixed, img2pdf will likely work as well.

By Tuan Hoang on 2019-05-18T22:22:50.701Z

Thanks for the explanation. I'm closing this issue.

By Tuan Hoang on 2019-05-18T22:22:51.102Z

Status changed to closed

*By Tuan Hoang on 2019-05-18T20:33:33.712Z* Hello, I'm seeing a couple of test failures on Alpine s390x. Would you mind having a look ? The build log could be found at : https://build.alpinelinux.org/buildlogs/build-3-10-s390x/community/py-img2pdf/py-img2pdf-0.3.3-r1.log Or back up at : http://tpaste.us/YM6r Thanks, --- *By Tuan Hoang on 2019-05-18T20:36:07.440Z* --- And this is how Alpine buildscript looks like : https://git.alpinelinux.org/aports/tree/community/py-img2pdf/APKBUILD img2pdf builds fine on Alpine on other little endian architectures like x86 and ppc64le. --- *By josch on 2019-05-18T21:22:38.860Z* --- The log looks more like a PIL/Pillow problem. Are you running PIL/Pillow test suites on Alpine under s390x? --- *By josch on 2019-05-18T21:44:49.495Z* --- I just ran the testsuite on s390x on Debian unstable where this worked fine so this seems to be Alpine specific and not a problem with s390x in general. Could you maybe just try creating an empty image with your PIL implementatation on Alpine on s390x and run the tobytes() member function of the image? That is the one that seems to fail. --- *By Tuan Hoang on 2019-05-18T21:50:54.407Z* --- Looks like Alpine s390x does not run py-pillow testsuites : https://git.alpinelinux.org/aports/tree/main/py-pillow/APKBUILD#n17 (meaning `make check` is not run). I disabled it a while ago: https://git.alpinelinux.org/aports/commit/main/py-pillow/APKBUILD?id=b65c2c0c9a5606eabd0361fa4e03c981bd0f17be. It's a known from upstream pillow. --- *By Tuan Hoang on 2019-05-18T21:56:30.218Z* --- ``` Could you maybe just try creating an empty image with your PIL implementatation on Alpine on s390x and run the tobytes() member function of the image? That is the one that seems to fail. ``` Would you mind explaining 'image' ? --- *By josch on 2019-05-18T22:08:58.783Z* --- This small snippet should throw an error on s390x alpine: python3 -c 'from PIL import Image; img=Image.new("RGB", (10,10));img.tobytes()' --- *By Tuan Hoang on 2019-05-18T22:12:46.269Z* --- Yes. ``` Traceback (most recent call last): File "<string>", line 1, in <module> File "/usr/lib/python3.7/site-packages/PIL/Image.py", line 756, in tobytes l, s, d = e.encode(bufsize) MemoryError ``` In fact Fedora's pillow also skips test on s390x. Looking at Debian build and patches, I couldn't see how it does not face the test failures. --- *By josch on 2019-05-18T22:15:49.682Z* --- In that case, this is not an img2pdf problem. If PIL doesn't work on Alpine on s390x, then img2pdf (which depends on PIL) cannot work on it either. And to fix it, you have to change PIL in Alpine and not img2pdf. Once your PIL is fixed, img2pdf will likely work as well. --- *By Tuan Hoang on 2019-05-18T22:22:50.701Z* --- Thanks for the explanation. I'm closing this issue. --- *By Tuan Hoang on 2019-05-18T22:22:51.102Z* --- Status changed to closed