josch/img2pdf
3
6
Fork 10
Code Issues 22 Pull requests 5 Projects Releases 3 Wiki Activity

Page box borders computed with wrong formula #92

New issue
Closed
opened 2021-04-25 19:59:03 +00:00 by josch · 0 comments
josch commented 2021-04-25 19:59:03 +00:00
Owner
Copy link

By jbarlow83 on 2021-03-25T20:26:10.960Z

img2pdf uses, for example:pagewidth - 2 * cropborder[1].
The correct formula is pagewidth - cropborder[1], because PDF rectangles specify the right-side coordinates [llx, lly, urx, ury] rather than one coordinate, width and height.

To illustrate the issue, if you set cropborder to 1 inch all around (72, 72), a PDF reader will actually crop the top and right by 2 inches.

By josch on 2021-04-13T16:29:22.670Z

Status changed to closed by commit 81325d3998

*By jbarlow83 on 2021-03-25T20:26:10.960Z* img2pdf uses, for example:`pagewidth - 2 * cropborder[1]`. The correct formula is `pagewidth - cropborder[1]`, because PDF rectangles specify the right-side coordinates [llx, lly, urx, ury] rather than one coordinate, width and height. To illustrate the issue, if you set cropborder to 1 inch all around (72, 72), a PDF reader will actually crop the top and right by 2 inches. --- *By josch on 2021-04-13T16:29:22.670Z* --- Status changed to closed by commit 81325d39983ba828f809061970f15f3969921271
josch closed this issue 2021-04-25 19:59:04 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
0.5.1
0.5.0
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.3.6
0.3.5
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.2.4
0.2.3
0.2.2
0.2.1
0.1.5.dev
0.2.0
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
forwarded

not an img2pdf bug but in a dependency

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
forwarded
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: josch/img2pdf#92
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?