From dd774b4f2008d98220ef3a24e959c21d0fcf27f9 Mon Sep 17 00:00:00 2001 From: Johannes Schauer Marin Rodrigues Date: Sun, 5 Mar 2023 15:26:37 +0100 Subject: [PATCH] tests: skip debootstrap tests variant - on oldstable because of #917773 --- coverage.txt | 3 +++ tests/as-debootstrap-unshare-wrapper | 1 - tests/check-against-debootstrap-dist | 17 ----------------- 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/coverage.txt b/coverage.txt index f49751f..1cb95bf 100644 --- a/coverage.txt +++ b/coverage.txt @@ -3,18 +3,21 @@ Dists: any Variants: minbase buildd - Needs-Root: true Needs-APT-Config: true +Skip-If: variant == "-" and dist == "oldstable" #917773 Test: check-against-debootstrap-dist Dists: any Variants: minbase buildd - Needs-Root: true Needs-APT-Config: true +Skip-If: variant == "-" and dist == "oldstable" #917773 Test: as-debootstrap-unshare-wrapper Modes: unshare Needs-Root: true Variants: minbase - Needs-APT-Config: true +Skip-If: variant == "-" and dist == "oldstable" #917773 Test: help diff --git a/tests/as-debootstrap-unshare-wrapper b/tests/as-debootstrap-unshare-wrapper index 0473983..47c6d62 100644 --- a/tests/as-debootstrap-unshare-wrapper +++ b/tests/as-debootstrap-unshare-wrapper @@ -89,7 +89,6 @@ rm /tmp/debian-mm/var/cache/apt/archives/lock rm /tmp/debian-mm/var/lib/apt/lists/lock rm /tmp/debian-mm/var/lib/dpkg/arch -# workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917773 # also needed for users that are created by systemd-sysusers before systemd 252 # https://github.com/systemd/systemd/pull/24534 for f in shadow shadow-; do diff --git a/tests/check-against-debootstrap-dist b/tests/check-against-debootstrap-dist index d51dc27..25f4c24 100644 --- a/tests/check-against-debootstrap-dist +++ b/tests/check-against-debootstrap-dist @@ -183,23 +183,6 @@ if [ "{{ VARIANT }}" = "-" ]; then esac fi -# workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917773 -case {{ DIST }} in oldstable|stable) -for f in shadow shadow-; do - if [ ! -e /tmp/debian-{{ DIST }}-mm/etc/$f ]; then - continue - fi - if ! cmp /tmp/debian-{{ DIST }}-debootstrap/etc/$f /tmp/debian-{{ DIST }}-mm/etc/$f >&2; then - echo patching /etc/$f on {{ DIST }} {{ VARIANT }} >&2 - awk -v FS=: -v OFS=: -v SDE={{ SOURCE_DATE_EPOCH }} '{ print $1,$2,int(SDE/60/60/24),$4,$5,$6,$7,$8,$9 }' < /tmp/debian-{{ DIST }}-mm/etc/$f > /tmp/debian-{{ DIST }}-mm/etc/$f.bak - cat /tmp/debian-{{ DIST }}-mm/etc/$f.bak > /tmp/debian-{{ DIST }}-mm/etc/$f - rm /tmp/debian-{{ DIST }}-mm/etc/$f.bak - else - echo no difference for /etc/$f on {{ DIST }} {{ VARIANT }} >&2 - fi -done;; -esac - # check if the file content differs diff --unified --no-dereference --recursive /tmp/debian-{{ DIST }}-debootstrap /tmp/debian-{{ DIST }}-mm >&2