UI broken, possibly due to screen DPI

stasiana commented

2024-01-14 22:08:16 +00:00

I use 4K screens on Debian 12. The UI shows poorly, with options off-screen. See the attachment.

Screenshot from 2024-01-14 14-07-27.png

132 KiB

stasiana changed title from ~~UI broken, possibly due to PDI~~ to UI broken, possibly due to screen DPI

2024-01-14 22:08:47 +00:00

josch commented

2024-01-14 22:16:30 +00:00

Owner

Thank you for your report! Are you able to test a patch if I send you one here?

stasiana commented

2024-01-14 23:21:44 +00:00

Author

Thank you for your report! Are you able to test a patch if I send you one here?

Sure thing.

> Thank you for your report! Are you able to test a patch if I send you one here? Sure thing.

josch commented

2024-01-14 23:48:11 +00:00

Owner

What happens if you change this number:

--- a/plakativ.py
+++ b/plakativ.py
@@ -942,7 +942,7 @@ class VerticalScrolledFrame(tkinter.Frame):
             borderwidth=0,
             highlightthickness=0,
             yscrollcommand=vscrollbar.set,
-            width=240 * parent.winfo_fpixels("1i") / 96.0,
+            width=440 * parent.winfo_fpixels("1i") / 96.0,
         )
         canvas.pack(side=tkinter.LEFT, fill=tkinter.BOTH, expand=tkinter.TRUE)
         vscrollbar.config(command=canvas.yview)

It would also be interesting to see what your system prints for this command:

python3 -c 'import tkinter; root = tkinter.Tk(); print(root.winfo_fpixels("1i"))'

Thanks!

What happens if you change this number: ```patch --- a/plakativ.py +++ b/plakativ.py @@ -942,7 +942,7 @@ class VerticalScrolledFrame(tkinter.Frame): borderwidth=0, highlightthickness=0, yscrollcommand=vscrollbar.set, - width=240 * parent.winfo_fpixels("1i") / 96.0, + width=440 * parent.winfo_fpixels("1i") / 96.0, ) canvas.pack(side=tkinter.LEFT, fill=tkinter.BOTH, expand=tkinter.TRUE) vscrollbar.config(command=canvas.yview) ``` It would also be interesting to see what your system prints for this command: python3 -c 'import tkinter; root = tkinter.Tk(); print(root.winfo_fpixels("1i"))' Thanks!

stasiana commented

2024-01-14 23:59:52 +00:00

Author

Great, that worked. Fatter bar makes all the options visible.

$ python3 -c 'import tkinter; root = tkinter.Tk(); print(root.winfo_fpixels("1i"))'
96.0

Great, that worked. Fatter bar makes all the options visible. ``` $ python3 -c 'import tkinter; root = tkinter.Tk(); print(root.winfo_fpixels("1i"))' 96.0 ```

josch commented

2024-01-15 07:30:46 +00:00

Owner

Okay, then we also have the culprit there. Tk thinks that your monitor dpi is 96 which is the same value that Tk presents for my monitor. If you have a 4k screen, that dpi value should probably be far larger. In that case, this is not a plakativ bug, but a bug in tk or elsewhere which feeds wrong data to plakativ which is using the dpi value to compute the correct size of the right-hand-side bar.

UI broken, possibly due to screen DPI #7