@monobot no problem! I just wanted to give you the opportunity to test if those changes do what you expect. That way we reduce the chance of me fixing something that is not really the problem you…
Aha, so past-me was smart and knew how to correctly compare enums and present-me forgot about it. Thanks! I'll adjust the code such that enums are always compared by identity.
Today we learned…
Here is a patch that should work:
diff --git a/src/img2pdf.py b/src/img2pdf.py
index 06f2e7b..ee7acfc 100755
--- a/src/img2pdf.py
+++ b/src/img2pdf.py
@@ -1436,11 +1445,22 @@ def…
Aha, whoops, sorry, when you wrote:
But I'll take a look into it.
I thought that I had to wait for a follow-up. Sorry for the misunderstanding! :)
I now looked into it a bit more and…
Yeah, sorry. I should have looked more thoroughly before commenting.
No worries! Better a few comments that have issues than not giving input at all. I like it when people would tell me about…
I'm not much of a pythonista, nor am I used to dealing with patch files, it may take me a bit of time to figure out how to apply the patch locally.
After cloning the git, you can run this to…
How about
@mara0004 replacing color != Colorspace.RGBA and color != Colorspace.LA with color not in (Colorspace.RGBA, Colorspace.LA) is a good improvement. The other though is incorrect…
This patch should fix your problem. Can you confirm?
diff --git a/src/img2pdf.py b/src/img2pdf.py
index 06f2e7b..57a8506 100755
--- a/src/img2pdf.py
+++ b/src/img2pdf.py
@@ -827,8…
This should not happen. Can you provide an example image so that I can reproduce your problem?
From my understanding the NUL is the ASCII Charater with Code 0
Correct.
/path/file name 1.jpg\0/path/file name 2.jpg\0
What platform are you on? In what language are you trying to…
Thank you for your tests! For what it's worth, my own computer is also an arm64 machine, so it is more likely for architecture specific problems on amd64/x86_64 to creep up because I don't have an…
Yes, what @mara0004 said is correct. If somebody wants to do lossly conversion, then imagemagick already exists and can take care of this. No need for img2pdf if lossy is fine for you. There are…
You are right, the warning should include what to do if one is fine with lossy conversion. How about the following patch:
diff --git a/src/img2pdf.py b/src/img2pdf.py
index 54701c9..79…