mara0004
  • Joined on May 04, 2021
Loading Heatmap…

mara0004 commented on issue josch/img2pdf#85

Some 0.4.0 test failures on Fedora

^^ There seem to be issues with spam on Muffin Gitea?

3 days ago

mara0004 commented on issue josch/img2pdf#158

Unnecessary conversion to RGB in case of a palette-based PNG with a transparency

You might also want to handle `PA` mode? Apparently your image is `P` but has `"transparency" in newimg.info`? I'm wondering why Pillow does not treat that as `PA` directly...

1 week ago

mara0004 commented on issue josch/img2pdf#157

Feature request: set DPI

Does the option `--imgsize` / `-s` help you? Quoting the help (formatting mine): ```txt -s LxL, --imgsize LxL Sets the size of the images on the PDF pages. In addition, the unit dpi is allowed…

3 weeks ago

mara0004 commented on issue josch/img2pdf#150

Output is not deterministic unless using `--engine=internal`

I think one can pass `static_id=True` to [`pikepdf.Pdf.save()`](https://pikepdf.readthedocs.io/en/latest/api/main.html#pikepdf.Pdf.save). However, `--nodate` only implies dates, so maybe a…

6 months ago

mara0004 deleted branch pillow_heif from mara0004/img2pdf

6 months ago

mara0004 commented on issue josch/img2pdf#105

HEIC support?

Thanks, sorry it took me so long to realise that it's not really appropriate to do this in img2pdf itself. Sometimes I need to attempt an implementation to actually get the problem.

6 months ago

mara0004 closed pull request josch/img2pdf#149

CLI: optional HEIF support

6 months ago

mara0004 commented on pull request josch/img2pdf#149

CLI: optional HEIF support

I think I'm going to close this. Come to think of it, if callers really want to convert HEIF to PDF losslessly, they can just convert the image to PNG and then pass it through img2pdf - that's…

6 months ago

mara0004 commented on pull request josch/img2pdf#149

CLI: optional HEIF support

Hmm, considering that HEIF may have an alpha channel, we'd need to adjust some related `if` checks. I can also look into writing a test case marked with `pytest.skipif()`.

6 months ago

mara0004 commented on issue josch/img2pdf#105

HEIC support?

https://gitlab.mister-muffin.de/josch/img2pdf/pulls/149

6 months ago

mara0004 created pull request josch/img2pdf#149

CLI: optional HEIF support

6 months ago

mara0004 created branch pillow_heif in mara0004/img2pdf

6 months ago

mara0004 pushed to pillow_heif at mara0004/img2pdf

6 months ago

mara0004 created repository mara0004/img2pdf

6 months ago

mara0004 commented on issue josch/img2pdf#105

HEIC support?

> If, on the other hand, there is somebody else willing to work on this and maintain it long term, I'd be merging that patch. I could take care of it, but "long term" is a difficult topic.…

6 months ago

mara0004 commented on issue josch/img2pdf#105

HEIC support?

Well, as you mentioned above, converting HEIF with img2pdf is rather inadvisable due to the increase in file size anyway, so this of low importance. However, I do have some comments on your…

6 months ago

mara0004 commented on issue josch/img2pdf#105

HEIC support?

Sorry, I don't understand the connection - `pillow_heif` has wheels on PyPI. The fact that it is not currently included in Linux distribution repositories doesn't mean it's not testable, does it?

6 months ago

mara0004 commented on issue josch/img2pdf#105

HEIC support?

Hmm, yes, but what about CLI users? Couldn't img2pdf initialise pillow_heif in its `main()` function?

6 months ago

mara0004 commented on issue josch/img2pdf#105

HEIC support?

> There is nothing that img2pdf can do about this. Could you clarify why you think `pillow_heif` is not an option for img2pdf?

6 months ago

mara0004 commented on issue josch/img2pdf#127

Memory 'leak'

Yes, indeed. Thanks and sorry for the excessive noise!

8 months ago