• Joined on 2021-08-18
sbraz commented on pull request josch/img2pdf#117 2021-08-20 23:35:36 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

Hi @josch, do you agree with the changes? If so, I will backport this patch to the Gentoo package so we can have working tests again.

If not, please let me know and I'll update the PR accordingly.

sbraz pushed to im7 at sbraz/img2pdf 2021-08-19 17:56:23 +00:00
d60b5109e0 README: fix CI URLs
152f6fb629 tests: look for sRGB.icc in several paths, skip related tests if not found
56c7c3988d README: fix CI URLs
bde1da0121 tests: look for sRGB.icc in several paths, skip related tests if not found
Compare 4 commits »
sbraz pushed to im7 at sbraz/img2pdf 2021-08-19 17:54:58 +00:00
56c7c3988d README: fix CI URLs
bde1da0121 tests: look for sRGB.icc in several paths, skip related tests if not found
b0e5f5189f README: fix CI URLs
b100e9be4f tests: look for sRGB.icc in several paths, skip related tests if not found
Compare 4 commits »
sbraz commented on pull request josch/img2pdf#117 2021-08-19 12:02:14 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

Pushed with globs that should work on a lot of well-known distros. I've removed the line that installs ICC packages from the Travis CI file since we'll only rely on Ghostscript's profile.

I have…

sbraz pushed to im7 at sbraz/img2pdf 2021-08-19 11:59:53 +00:00
b0e5f5189f README: fix CI URLs
b100e9be4f tests: look for sRGB.icc in several paths, skip related tests if not found
9036ff860c tests: look for sRGB.icc in several paths, skip related tests if not found
Compare 3 commits »
sbraz pushed to im7 at sbraz/img2pdf 2021-08-19 11:43:20 +00:00
9036ff860c tests: look for sRGB.icc in several paths, skip related tests if not found
2c287a6e98 tests: look for sRGB.icc in several paths, skip related tests if not found
Compare 2 commits »
sbraz commented on pull request josch/img2pdf#117 2021-08-19 11:41:00 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

As far as I can tell, the compare function is never called with icc=True so it is effectively unused. compare_pdfimages_png is called with icc=True and either the OpenICC profile my distro…

sbraz pushed to im7 at sbraz/img2pdf 2021-08-19 11:39:44 +00:00
2c287a6e98 tests: look for sRGB.icc in several paths, skip related tests if not found
1f3b456ac9 tests: don't expect ImageMagick to compress TIFF files by default
4c5b72dab0 src/img2pdf_test.py: skip tests when icc profiles are not present
853a1ec363 src/img2pdf_test.py: do not test format descriptions
4166367318 tests: vendor sRGB.icc instead of relying on distro-specific paths
Compare 7 commits »
sbraz commented on pull request josch/img2pdf#117 2021-08-19 11:18:19 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

Thanks, I'll look into possible paths for it. Did you see my other question?

Do you need different ICC profiles (the one from icc-profiles and the one from Ghostscript) or can we use the same for…

sbraz commented on pull request josch/img2pdf#117 2021-08-19 10:47:18 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

test different paths

If you agree, I can probably do something like this (untested pseudo-Python):

ICC_PROFILE = None
for path in ["/usr/share/path1", "/usr/share/path2"]:
    if
sbraz commented on pull request josch/img2pdf#117 2021-08-19 10:40:37 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

And why should I reject #110 in favor of the changes of this pull request?

Oh, that is not what I meant. I only noticed #110 after I fixed the tests. I can simply rebase once you merge it.

As…

sbraz created pull request josch/img2pdf#117 2021-08-19 00:19:18 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111
sbraz pushed to im7 at sbraz/img2pdf 2021-08-18 23:42:47 +00:00
4166367318 tests: vendor sRGB.icc instead of relying on distro-specific paths
dfcaa52bec tests: don't expect ImageMagick to compress TIFF files by default
a143e31eb1 tests: don't check formatDescription
Compare 3 commits »
sbraz created branch im7 in sbraz/img2pdf 2021-08-18 23:42:44 +00:00
sbraz created repository sbraz/img2pdf 2021-08-18 23:41:33 +00:00