Hi @josch, do you agree with the changes? If so, I will backport this patch to the Gentoo package so we can have working tests again.
If not, please let me know and I'll update the PR accordingly.
Pushed with globs that should work on a lot of well-known distros. I've removed the line that installs ICC packages from the Travis CI file since we'll only rely on Ghostscript's profile.
I have…
As far as I can tell, the compare
function is never called with icc=True
so it is effectively unused. compare_pdfimages_png
is called with icc=True
and either the OpenICC profile my distro…
Thanks, I'll look into possible paths for it. Did you see my other question?
Do you need different ICC profiles (the one from icc-profiles and the one from Ghostscript) or can we use the same for…
test different paths
If you agree, I can probably do something like this (untested pseudo-Python):
ICC_PROFILE = None
for path in ["/usr/share/path1", "/usr/share/path2"]:
if…
And why should I reject #110 in favor of the changes of this pull request?
Oh, that is not what I meant. I only noticed #110 after I fixed the tests. I can simply rebase once you merge it.
As…