josch/img2pdf
3
6
Fork 10
Code Issues 22 Pull requests 5 Projects Releases 3 Wiki Activity

src/img2pdf_test.py: do not test format descriptions #110

Merged
josch merged 2 commits from paper/img2pdf:tests-no-description into main 2021-08-19 10:59:48 +00:00
Conversation 4 Commits 2 Files changed 1 -172
paper commented 2021-07-04 21:12:40 +00:00
Contributor
Copy link

There is no need to test the format description when the format code is tested before. Descriptions can change, codes shouldn't.

There is no need to test the format description when the format code is tested before. Descriptions can change, codes shouldn't.
paper added 1 commit 2021-07-04 21:13:02 +00:00
josch commented 2021-07-05 04:49:46 +00:00
Owner
Copy link

The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074

If the JSON output changed without a version bump, then that's a bug in imagemagick.

The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074 If the JSON output changed without a version bump, then that's a bug in imagemagick.
paper commented 2021-07-05 12:39:59 +00:00
Author
Contributor
Copy link

The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074

If the JSON output changed without a version bump, then that's a bug in imagemagick.

I don't think there is a reason to test this, the correctness is already tested on the line above. This PR fixes these tests for imagemagick 7 while being compatible with imagemagick 6.

> The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074 > > If the JSON output changed without a version bump, then that's a bug in imagemagick. I don't think there is a reason to test this, the correctness is already tested on the line above. This PR fixes these tests for imagemagick 7 while being compatible with imagemagick 6.
josch commented 2021-07-05 13:36:41 +00:00
Owner
Copy link

I'm not saying you are wrong and I'm not saying that I won't accept your pull request (thanks for preparing it!) -- but I first want to contact the imagemagick developers about this issue because the format shouldn't have changed without a version bump.

I'm not saying you are wrong and I'm not saying that I won't accept your pull request (thanks for preparing it!) -- but I first want to contact the imagemagick developers about this issue because the format shouldn't have changed without a version bump.
paper commented 2021-07-05 14:20:46 +00:00
Author
Contributor
Copy link

I think we don't understand each other, the description changed with a version bump - 6 to 7.

I think we don't understand each other, the description changed **with** a version bump - 6 to 7.
josch added 1 commit 2021-08-19 10:58:22 +00:00
josch merged commit 853a1ec363 into main 2021-08-19 10:59:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
forwarded

not an img2pdf bug but in a dependency

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
forwarded
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: josch/img2pdf#110
No description provided.
Delete branch "paper/img2pdf:tests-no-description"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?