josch
/
img2pdf
3
5
Fork 9
Code Issues 18 Pull Requests 1 Projects Releases 3 Wiki Activity

Labels Milestones

src/img2pdf_test.py: do not test format descriptions #110

Merged
josch merged 2 commits from paper/img2pdf:tests-no-description into main 3 years ago
Conversation 4 Commits 2 Files Changed 1
paper commented 3 years ago

There is no need to test the format description when the format code is tested before. Descriptions can change, codes shouldn't.

There is no need to test the format description when the format code is tested before. Descriptions can change, codes shouldn't.
josch commented 3 years ago
Owner

The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074

If the JSON output changed without a version bump, then that's a bug in imagemagick.

The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074 If the JSON output changed without a version bump, then that's a bug in imagemagick.
paper commented 3 years ago
Poster

The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074

If the JSON output changed without a version bump, then that's a bug in imagemagick.

I don't think there is a reason to test this, the correctness is already tested on the line above. This PR fixes these tests for imagemagick 7 while being compatible with imagemagick 6.

> The descriptions cannot change either. The JSON Format is not supposed to change unless its version is bumped: https://github.com/ImageMagick/ImageMagick6/issues/90#issuecomment-668281074 > > If the JSON output changed without a version bump, then that's a bug in imagemagick. I don't think there is a reason to test this, the correctness is already tested on the line above. This PR fixes these tests for imagemagick 7 while being compatible with imagemagick 6.
josch commented 3 years ago
Owner

I'm not saying you are wrong and I'm not saying that I won't accept your pull request (thanks for preparing it!) -- but I first want to contact the imagemagick developers about this issue because the format shouldn't have changed without a version bump.

I'm not saying you are wrong and I'm not saying that I won't accept your pull request (thanks for preparing it!) -- but I first want to contact the imagemagick developers about this issue because the format shouldn't have changed without a version bump.
paper commented 3 years ago
Poster

I think we don't understand each other, the description changed with a version bump - 6 to 7.

I think we don't understand each other, the description changed **with** a version bump - 6 to 7.
josch merged commit 853a1ec363 into main 3 years ago
The pull request has been merged as 853a1ec363.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b paper-tests-no-description main
git pull tests-no-description

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff paper-tests-no-description
git push origin main
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
forwarded

not an img2pdf bug but in a dependency   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
forwarded
help wanted
invalid
question
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: josch/img2pdf#110
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'paper/img2pdf:tests-no-description'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes