josch/img2pdf
3
6
Fork 10
Code Issues 22 Pull requests 5 Projects Releases 3 Wiki Activity

src/img2pdf_test.py: do not test format descriptions #110

Merged
josch merged 2 commits from paper/img2pdf:tests-no-description into main 2021-08-19 10:59:48 +00:00
Conversation 4 Commits 2 Files changed 1 +14 -4
2 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit bb8a2d8b3a - Show all commits

12
README.md
View file

@ -80,7 +80,17 @@ Bugs
- Input images with alpha channels are not allowed. PDF only supports - Input images with alpha channels are not allowed. PDF only supports
transparency using binary masks but is unable to store 8-bit transparency transparency using binary masks but is unable to store 8-bit transparency
information as part of the image itself. But img2pdf will always be lossless information as part of the image itself. But img2pdf will always be lossless
and thus, input images must not carry transparency information. and thus, input images must not carry transparency information. You can
remove the alpha channel for example with imagemagick:
convert input.png -background white -alpha remove -alpha off output.png
- An error is produced if the input image is broken. This commonly happens if
the input image has an invalid EXIF Orientation value of zero. Even though
only nine different values from 1 to 9 are permitted, Anroid phones and
Canon DSLR cameras produce JPEG images with the invalid value of zero.
Either fix your input images with `exiftool` or similar software before
passing the JPEG to `img2pdf` or run `img2pdf` with `--rotation=ifvalid`.
- img2pdf uses PIL (or Pillow) to obtain image meta data and to convert the - img2pdf uses PIL (or Pillow) to obtain image meta data and to convert the
input if necessary. To prevent decompression bomb denial of service attacks, input if necessary. To prevent decompression bomb denial of service attacks,

6
src/img2pdf.py
View file

@ -2651,7 +2651,6 @@ def gui():
args = { args = {
"engine": tkinter.StringVar(), "engine": tkinter.StringVar(),
"first_frame_only": tkinter.BooleanVar(),
"auto_orient": tkinter.BooleanVar(), "auto_orient": tkinter.BooleanVar(),
"fit": tkinter.StringVar(), "fit": tkinter.StringVar(),
"title": tkinter.StringVar(), "title": tkinter.StringVar(),
@ -3611,8 +3610,9 @@ ifvalid, 0, 90, 180 and 270. The default value is auto and indicates that input
images are rotated according to their EXIF Orientation tag. The values none and images are rotated according to their EXIF Orientation tag. The values none and
0 ignore the EXIF Orientation values of the input images. The value ifvalid 0 ignore the EXIF Orientation values of the input images. The value ifvalid
acts like auto but ignores invalid EXIF rotation values and only issues a acts like auto but ignores invalid EXIF rotation values and only issues a
warning instead of throwing an error. The values 90, 180 and 270 perform a warning instead of throwing an error. This is useful because many devices like
clockwise rotation of the image. Android phones, Canon cameras or scanners emit an invalid Orientation tag value
of zero. The values 90, 180 and 270 perform a clockwise rotation of the image.
""", """,
) )
sizeargs.add_argument( sizeargs.add_argument(