CLI: optional HEIF support

mara0004 commented

2022-09-24 12:35:33 +00:00

Contributor

Suggestion for #105

However, the increase in file size is really enormous, and considering the other difficulties we discussed, I'm not sure anymore if it's a good idea.

Suggestion for https://gitlab.mister-muffin.de/josch/img2pdf/issues/105 However, the increase in file size is really enormous, and considering the other difficulties we discussed, I'm not sure anymore if it's a good idea.

mara0004 added 1 commit 2022-09-24 12:35:35 +00:00

CLI: optional HEIF support 37e8fa5e09

mara0004 referenced this pull request

2022-09-24 12:36:08 +00:00

HEIC support? #105

mara0004 commented

2022-09-24 12:39:22 +00:00

Author

Contributor

Hmm, given that HEIF images may have an alpha channel, we'd need to adjust some related if checks. I can also look into writing a test case marked with pytest.skipif().

Hmm, given that HEIF images may have an alpha channel, we'd need to adjust some related `if` checks. I can also look into writing a test case marked with `pytest.skipif()`.

mara0004 commented

2022-09-24 12:57:08 +00:00

Author

Contributor

I think I'm going to close this. Come to think of it, if callers really want to convert HEIF to PDF losslessly, they can just convert the image to PNG and then pass it through img2pdf - that's equivalent and safes the img2pdf codebase from additional complication.

mara0004 closed this pull request

2022-09-24 12:57:09 +00:00