CLI: optional HEIF support #149

Closed
mara0004 wants to merge 1 commits from <deleted>:pillow_heif into main

Suggestion for #105

However, the increase in file size is really enormous, and considering the other difficulties we discussed, I'm not sure anymore if it's a good idea.

Suggestion for https://gitlab.mister-muffin.de/josch/img2pdf/issues/105 However, the increase in file size is really enormous, and considering the other difficulties we discussed, I'm not sure anymore if it's a good idea.
mara0004 added 1 commit 2 years ago
Poster

Hmm, given that HEIF images may have an alpha channel, we'd need to adjust some related if checks. I can also look into writing a test case marked with pytest.skipif().

Hmm, given that HEIF images may have an alpha channel, we'd need to adjust some related `if` checks. I can also look into writing a test case marked with `pytest.skipif()`.
Poster

I think I'm going to close this. Come to think of it, if callers really want to convert HEIF to PDF losslessly, they can just convert the image to PNG and then pass it through img2pdf - that's equivalent and safes the img2pdf codebase from additional complication.

I think I'm going to close this. Come to think of it, if callers really want to convert HEIF to PDF losslessly, they can just convert the image to PNG and then pass it through img2pdf - that's equivalent and safes the img2pdf codebase from additional complication.
mara0004 closed this pull request 2 years ago
josch commented 2 years ago
Owner

Thank you for looking into this! It's nevertheless helpful to have your comments for any future developments into that direction. :)

Thank you for looking into this! It's nevertheless helpful to have your comments for any future developments into that direction. :)
mara0004 deleted branch pillow_heif 2 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: josch/img2pdf#149
Loading…
There is no content yet.