josch/img2pdf
3
7
Fork 12
Code Issues 27 Pull requests 1 Projects Releases 4 Wiki Activity

test-nopdfrw #211

Open
gms wants to merge 2 commits from gms:test-nopdfrw into main
pull from: gms:test-nopdfrw
merge into: josch:main
Conversation 3 Commits 2 Files changed 2 +1 -2
gms commented 2025-09-27 12:13:56 +00:00
First-time contributor
Copy link

Noticed during modernizing the Fedora package, i.e. tox.ini can be used to install the test dependencies and thus one doesn't have to specify those redundantly.

Noticed during modernizing the Fedora package, i.e. tox.ini can be used to install the test dependencies and thus one doesn't have to specify those redundantly.
since pdfrw was removed from tests in release 0.4.2
including tox.ini simplifies executing the tests in distribution
packages or by users who download the relase tar archive instead of
cloning the git repository
josch reviewed 2025-10-30 09:11:00 +00:00
MANIFEST.in
@ -1,6 +1,6 @@
include README.md
include test_comp.sh
include test.sh
josch commented 2025-10-30 09:11:00 +00:00
Owner
Copy link

You removed test.sh (which is fine because it no longer exists) -- would you like to also remove magick.py which was removed in the same commit as test.sh got removed? You could also split this off into another commit as the removal of test.sh and magick.py has nothing to do with your addition of tox.ini.

I can also take care of it if you are short on time.

Thank you!

You removed `test.sh` (which is fine because it no longer exists) -- would you like to also remove `magick.py` which was removed in the same commit as `test.sh` got removed? You could also split this off into another commit as the removal of test.sh and magick.py has nothing to do with your addition of tox.ini. I can also take care of it if you are short on time. Thank you!
gms commented 2025-11-08 20:49:49 +00:00
Author
First-time contributor
Copy link

ok, no problem, removing magick.py also counts as cleanup, IMO.
I thus rebased my last commit and force pushed it to the branch the pull-request is based on:

a363c53ee0

However, this seems to confuse forejo and it now thinks that this pull request is broken.

I'm not sure if this is a general limitation of forejo or a more specific issue.

FWIW, updating a pull-request via force-push works on github, out of the box.

ok, no problem, removing magick.py also counts as cleanup, IMO. I thus rebased my last commit and force pushed it to the branch the pull-request is based on: https://gitlab.mister-muffin.de/gms/img2pdf/commit/a363c53ee0479347ae3c552d495eac9d67b80c1e However, this seems to confuse forejo and it now thinks that this pull request is broken. I'm not sure if this is a general limitation of forejo or a more specific issue. FWIW, updating a pull-request via force-push works on github, out of the box.
gms commented 2025-11-08 20:51:21 +00:00
Author
First-time contributor
Copy link

BTW, although my forejo account as email notifications enabled I wasn't notified about your comment via email.

I've checked my mailserver logs and didn't see any connection attemps to my email address on that day.

BTW, although my forejo account as email notifications enabled I wasn't notified about your comment via email. I've checked my mailserver logs and didn't see any connection attemps to my email address on that day.
gms commented 2025-11-09 11:37:43 +00:00
Author
First-time contributor
Copy link

Hm, locally rebasing that pull-request branch did work, but force-pushing it again doesn't help with forgejo considering this pull-request as broken.

Hm, locally rebasing that pull-request branch did work, but force-pushing it again doesn't help with forgejo considering this pull-request as broken.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u test-nopdfrw:gms-test-nopdfrw
git switch gms-test-nopdfrw

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff gms-test-nopdfrw
git switch gms-test-nopdfrw
git rebase main
git switch main
git merge --ff-only gms-test-nopdfrw
git switch gms-test-nopdfrw
git rebase main
git switch main
git merge --no-ff gms-test-nopdfrw
git switch main
git merge --squash gms-test-nopdfrw
git switch main
git merge --ff-only gms-test-nopdfrw
git switch main
git merge gms-test-nopdfrw
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
forwarded

not an img2pdf bug but in a dependency

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
forwarded
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: josch/img2pdf#211
No description provided.
Delete branch "gms:test-nopdfrw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?