josch/mmdebstrap
2
3
Fork 6
Code Issues 8 Pull requests 1 Projects Releases Wiki Activity

add sanity check for fakechroot/proot renameat2 bug

Browse source
This commit is contained in:
Johannes 'josch' Schauer 2018-10-24 02:41:43 +02:00
parent 3c411012be
commit 4c9d2bd3d7
Signed by: josch
GPG key ID: F2CBA5C78FBD83E1
1 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
mmdebstrap
View file

@ -1008,6 +1008,30 @@ sub setup {
} }
} }
# some versions of coreutils use the renameat2 system call in mv.
# This breaks certain versions of fakechroot and proot. Here we do
# a sanity check and warn the user in case things might break.
if (any { $_ eq $options->{mode} } ('fakechroot', 'proot') and -e "$options->{root}/bin/mv") {
mkdir "$options->{root}/000-move-me" or die "cannot create directory: $!";
my $ret = system @chrootcmd, '/bin/mv', '/000-move-me', '/001-delete-me';
if ($ret != 0) {
print STDERR "I: the /bin/mv binary inside the chroot doesn't work under ";
if ($options->{mode} eq 'proot') {
print STDERR "proot\n";
print STDERR "I: this is likely due to missing support for renameat2 in proot\n";
print STDERR "I: see https://github.com/proot-me/PRoot/issues/147\n";
} else {
print STDERR "fakechroot\n";
print STDERR "I: with certain versions of coreutils and glibc, this is due to missing support for renameat2 in fakechroot\n";
print STDERR "I: see https://github.com/dex4er/fakechroot/issues/60\n";
}
print STDERR "I: expect package post installation scripts not to work\n";
rmdir "$options->{root}/000-move-me" or die "cannot rmdir: $!";
} else {
rmdir "$options->{root}/001-delete-me" or die "cannot rmdir: $!";
}
}
# install the extracted packages properly # install the extracted packages properly
# we need --force-depends because dpkg does not take Pre-Depends into # we need --force-depends because dpkg does not take Pre-Depends into
# account and thus doesn't install them in the right order # account and thus doesn't install them in the right order