josch/mmdebstrap
2
3
Fork 6
Code Issues 8 Pull requests 1 Projects Releases Wiki Activity

also unmount in unshare mode to prevent wrong directory permissions of mount targets

Browse source
This commit is contained in:
Johannes 'josch' Schauer 2018-10-08 11:26:31 +02:00
parent ac8084cb42
commit 7412d5fbce
Signed by: josch
GPG key ID: F2CBA5C78FBD83E1
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
mmdebstrap
View file

@ -1135,10 +1135,19 @@ sub setup {
die "unsupported type: $type"; die "unsupported type: $type";
} }
} }
# no need to umount if the mount namespace was unshared # naturally we have to clean up after ourselves in sudo mode where we
if ($options->{mode} ne 'unshare') { # do a real mount. But we also need to unmount in unshare mode because
0 == system('umount', '--no-mtab', "$options->{root}/sys") or die "umount failed: $?"; # otherwise, even with the --one-file-system tar option, the
# permissions of the mount source will be stored and not the mount
# target (the directory)
if ($options->{mode} eq 'unshare') {
# since we cannot write to /etc/mtab we need --no-mtab
# unmounting /sys only seems to be successful with --lazy
0 == system('umount', '--no-mtab', '--lazy', "$options->{root}/sys") or die "umount failed: $?";
0 == system('umount', '--no-mtab', "$options->{root}/proc") or die "umount failed: $?"; 0 == system('umount', '--no-mtab', "$options->{root}/proc") or die "umount failed: $?";
} else {
0 == system('umount', "$options->{root}/sys") or die "umount failed: $?";
0 == system('umount', "$options->{root}/proc") or die "umount failed: $?";
} }
} }