josch/mmdebstrap
2
3
Fork 6
Code Issues 8 Pull requests 1 Projects Releases Wiki Activity

unset TMPDIR in hooks because there is no value that works inside as well as outside the chroot

Browse source
This commit is contained in:
Johannes Schauer Marin Rodrigues 2021-02-04 17:46:39 +01:00
parent 0595c5c220
commit c740b01dc8
Signed by: josch
GPG key ID: F2CBA5C78FBD83E1
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
mmdebstrap
View file

@ -1212,10 +1212,16 @@ sub run_hooks {
}
my @env_opts = ();
# There is no need to unset TMPDIR because we already have set it ourselves
# to "$options->{root}/tmp" in run_setup(). This is to have a writable
# TMPDIR even in unshare mode.
#
# At this point TMPDIR is set to "$options->{root}/tmp". This is to have a
# writable TMPDIR even in unshare mode. But if TMPDIR is still set when
# running hooks, then every hook script calling chroot, will have to wrap
# that into an "env --unset=TMPDIR". To avoid this, we unset TMPDIR here.
# If the hook script needs a writable TMPDIR, then it can always use /tmp
# inside the chroot. This is also why we do not set a new MMDEBSTRAP_TMPDIR
# environment variable.
if (defined $ENV{TMPDIR} && $ENV{TMPDIR} ne "") {
push @env_opts, '--unset=TMPDIR';
}
# The APT_CONFIG variable, if set, will confuse any manual calls to
# apt-get. If you want to use the same config used by mmdebstrap, the
# original value is stored in MMDEBSTRAP_APT_CONFIG.