josch commented on issue josch/img2pdf#152 2023-06-11 06:21:05 +00:00
A few test case failures on Fedora 37 with ImageMagick 7

The ValueError part of this issue should be fixed by 57d7e07e6badb252c12015388b58fcb5285d3158

Can you confirm?

josch commented on issue josch/img2pdf#155 2023-06-11 06:15:42 +00:00
PDF timestamp handling issue

Thank you!

I also added a bunch of test cases for this in b25429a4c11bd62171066e8b9caf1b80c610ee58 so that this problem doesn't happen again.

Could you try running pytest with the latest…

josch closed issue josch/img2pdf#135 2023-06-11 06:14:26 +00:00
MPO JPEGs from digital camera with thumbnails inserted as multiple frames
josch pushed to main at josch/img2pdf 2023-06-11 06:14:26 +00:00
85cbe1d128 factor out argparse.ArgumentParser to allow for generating completions via shtab
b25429a4c1 src/img2pdf_test.py: add tests for timestamps
c703e9df06 fix date(1) based timestamp parser
79e9985f35 src/img2pdf_test.py: black
cb2644c34f do not include thumbnails in the output by default unless --include-thumbnails is used
Compare 5 commits »
josch closed issue josch/img2pdf#155 2023-06-11 05:30:54 +00:00
PDF timestamp handling issue
josch pushed to main at josch/img2pdf 2023-06-11 05:30:54 +00:00
81502f21af Convert creation/modification dates to UTC (fixes #155)
josch merged pull request josch/img2pdf#168 2023-06-11 05:30:53 +00:00
Convert creation/modification dates to UTC (fixes #155)
josch commented on issue josch/img2pdf#155 2023-06-09 06:55:33 +00:00
PDF timestamp handling issue

This works for me both with pdfinfo as well as with evince:

diff --git a/src/img2pdf.py b/src/img2pdf.py
index 4300999..2acc0f6 100755
--- a/src/img2pdf.py
+++ b/src/img2pdf.py
@@…
josch commented on issue josch/img2pdf#155 2023-06-09 05:41:19 +00:00
PDF timestamp handling issue

I poked around a little bit more. I saw that you implemented some more code to represent the timezone offset properly. Would it not be easier to just store the timestamp in UTC instead of the…

josch closed issue josch/img2pdf#153 2023-06-09 04:58:51 +00:00
converting Jpg images that are around 800x10000 leaves very large white space between images.
josch closed issue josch/img2pdf#157 2023-06-09 04:58:34 +00:00
Feature request: set DPI
josch closed issue josch/img2pdf#131 2023-06-09 04:51:47 +00:00
Set background color?
josch commented on issue josch/img2pdf#135 2023-06-08 21:57:53 +00:00
MPO JPEGs from digital camera with thumbnails inserted as multiple frames

The following diff implements the --include-thumbnails option and does not include thumbnails by default. Could somebody try out if this does the right thing for them?

diff --git…
josch pushed to main at josch/img2pdf 2023-06-08 06:54:41 +00:00
0cbcb8fa12 avoid converting palette PNG with alpha to RGB (closes: #158)
e9e04b6dd9 extend comments around dropping ICC profile stored by GIMP for bilevel input
Compare 2 commits »
josch closed issue josch/img2pdf#158 2023-06-08 06:54:40 +00:00
Unnecessary conversion to RGB in case of a palette-based PNG with a transparency
josch commented on issue josch/img2pdf#159 2023-06-08 05:20:52 +00:00
GIMP 1bit PNGs (with metadata) bug

I've pushed some commits which will not include the ICC profile saved by GIMP for bilevel images. See #164 and https://gitlab.gnome.org/GNOME/gimp/-/issues/3438 for details.

Can you confirm…

josch commented on issue josch/img2pdf#166 2023-06-08 05:17:38 +00:00
Invalid Argument Error When Using Special Characters in Output Filename

Thank you for your input. I'm tempted to just close this issue because:

  • another Windows user is not able to reproduce it
  • i do not think that implementing platform specific filename…
josch pushed to main at josch/img2pdf 2023-06-08 05:14:33 +00:00
fc059ee471 use quotes around caret in examples for windows users
josch closed issue josch/img2pdf#167 2023-06-08 05:14:32 +00:00
Paper size transpose in Windows
josch commented on issue josch/img2pdf#169 2023-06-08 05:12:45 +00:00
CYGWIN install without pikepdf

I'm unsure what the best way forward is. Indeed pikepdf is not mandatory and img2pdf will work without it but produce slightly worse output. I'd like to see a solution where pikepdf is still…