josch pushed to main at josch/mmdebstrap 2024-10-11 20:26:46 +00:00
5055b1b44c tests/check-against-debootstrap-dist: since iputils-ping 20240905 there are no extended attributes anymore
c82fc7e261 format shell scripts with shfmt --binary-next-line --case-indent --indent 2 --simplify
eca6cb314c tests/tarfilter-idshift: use a fabricated tarball instead of real chroot
Compare 3 commits »
josch commented on issue josch/mmdebstrap#45 2024-09-20 10:02:27 +00:00
Unknown option: cache-dir

Yes, but if you do not want to use a caching proxy like apt-cacher-ng, you can also solve this problem by using a hook. If you write a good hook script, I can ship it together with the mmdebstrap…

josch commented on pull request josch/img2pdf#203 2024-09-15 06:03:03 +00:00
convert(): add option to get engine document (e.g. pikepdf.Pdf)

Please do not change the signature of the convert() function. This is necessary to preserve API stability. You have to extract "outputstream" from kwargs.

josch commented on pull request josch/img2pdf#203 2024-09-15 06:03:03 +00:00
convert(): add option to get engine document (e.g. pikepdf.Pdf)

You split tostream() into finalize() and tostream() but then why does the new tostream() not call finalize()?

josch suggested changes for josch/img2pdf#203 2024-09-15 06:03:03 +00:00
convert(): add option to get engine document (e.g. pikepdf.Pdf)

Thank you for your work and for your patience with me. I'm going to be on a business trip next week (I'm switching jobs end of september/beginning of october) so my next feedback might take a while but please feel free to ping me if you like.

josch commented on pull request josch/img2pdf#202 2024-09-15 05:54:41 +00:00
Slightly simplify the getexif procedure

It makes the code harder to read, yes. But the advantage is, that this way, recent versions of img2pdf keep working on older platforms and distributions that ship Pillow before version 6 are still…

josch commented on pull request josch/img2pdf#201 2024-09-15 05:48:02 +00:00
Slightly simplify imgformat retrieval

I updated the code to getattr(...) as drafted above. It's a one-liner now.

Thank you! Could you squash both commits into one?

josch commented on pull request josch/mmdebstrap#44 2024-09-13 12:41:56 +00:00
Add support for elxr

I was wondering why you check for "elxr" here. Debootstrap does not ship any such script or symlink and I do not see an open merge request on salsa nor an open bug in the Debian BTS. Is this an oversight or are you planning to add debootstrap support soon?

josch pushed to main at josch/mmdebstrap 2024-09-13 05:35:55 +00:00
395ee60a7f release 1.5.3
1a8f2537ac explain --pax-option with comment
0f5d935941 more sanity checks of target directory
dbce1ee27b fix typo
6e4ed4a049 add --skip=cleanup/reproducible/machine-id
Compare 9 commits »
josch pushed tag 1.5.3 to josch/mmdebstrap 2024-09-13 05:35:55 +00:00
josch commented on pull request josch/img2pdf#184 2024-09-11 09:45:27 +00:00
Add support for JBIG2 (generic coding)

@josch is this still blocked on anything? Anything I can do to get it merged?

Thank you for the ping and sorry to not have come back to you earlier. If in doubt, please feel free to ping me…

josch commented on pull request josch/plakativ#10 2024-09-03 07:42:09 +00:00
fix AttributeError with insertTextbox

Hi, thank you for your contribution. The pymupdf project is continuously breaking its api, converting functions from snake_case naming to CamelCase. Similar fixes have been performed in…

josch created branch main in josch/reform-debian-funding 2024-08-29 22:31:10 +00:00
josch pushed to main at josch/reform-debian-funding 2024-08-29 22:31:10 +00:00
6562c82af1 initial commit
josch created repository josch/reform-debian-funding 2024-08-29 22:30:56 +00:00
josch commented on pull request josch/mmdebstrap#44 2024-08-28 14:15:14 +00:00
Add support for elxr

Thank you! I'd like to use this opportunity to factor out all this information into some machine-readable text files. I'll see if I find time to do that this week.

josch commented on pull request josch/img2pdf#203 2024-08-27 21:57:23 +00:00
convert(): add option to get engine document (e.g. pikepdf.Pdf)

Kindly let me know if you are OK with it now, or if there's anything else to change.

What i had in mind was: take the convert function and put all the code that generates the pdf variable…

josch commented on pull request josch/img2pdf#200 2024-08-27 08:22:36 +00:00
Extract an API to predict the DPI used by img2pdf (with Pillow)

This change looks okay. Did you run the testsuite for your pull requests?

josch commented on pull request josch/img2pdf#201 2024-08-27 08:17:19 +00:00
Slightly simplify imgformat retrieval

No need for a loop here - we can access the enum like a dictionary.

Yes, if your python version is recent enough. Is there an objective reason to change this?

josch commented on pull request josch/img2pdf#202 2024-08-27 08:13:34 +00:00
Slightly simplify the getexif procedure

checks like these for _getexif are there for a reason. Could you try and find out what changed that does not make these necessary anymore and since when it is like that?