Hi,
I cannot tell you about bdebstrap but I can explain the mmdebstrap situation. This will expand $WORKROOT before passing it to mmdebstrap
--customize-hook="cp foo \"\$1\"/$WORKROOT"…Yes, but if you do not want to use a caching proxy like apt-cacher-ng, you can also solve this problem by using a hook. If you write a good hook script, I can ship it together with the mmdebstrap…
convert(): add option to get engine document (e.g. pikepdf.Pdf)
Please do not change the signature of the convert() function. This is necessary to preserve API stability. You have to extract "outputstream" from kwargs.
convert(): add option to get engine document (e.g. pikepdf.Pdf)
You split tostream() into finalize() and tostream() but then why does the new tostream() not call finalize()?
convert(): add option to get engine document (e.g. pikepdf.Pdf)
Thank you for your work and for your patience with me. I'm going to be on a business trip next week (I'm switching jobs end of september/beginning of october) so my next feedback might take a while but please feel free to ping me if you like.
It makes the code harder to read, yes. But the advantage is, that this way, recent versions of img2pdf keep working on older platforms and distributions that ship Pillow before version 6 are still…
I updated the code to
getattr(...)as drafted above. It's a one-liner now.
Thank you! Could you squash both commits into one?
I was wondering why you check for "elxr" here. Debootstrap does not ship any such script or symlink and I do not see an open merge request on salsa nor an open bug in the Debian BTS. Is this an oversight or are you planning to add debootstrap support soon?
@josch is this still blocked on anything? Anything I can do to get it merged?
Thank you for the ping and sorry to not have come back to you earlier. If in doubt, please feel free to ping me…
Hi, thank you for your contribution. The pymupdf project is continuously breaking its api, converting functions from snake_case naming to CamelCase. Similar fixes have been performed in…
Thank you! I'd like to use this opportunity to factor out all this information into some machine-readable text files. I'll see if I find time to do that this week.
convert(): add option to get engine document (e.g. pikepdf.Pdf)
Kindly let me know if you are OK with it now, or if there's anything else to change.
What i had in mind was: take the convert function and put all the code that generates the pdf variable…