Hi,
I cannot tell you about bdebstrap
but I can explain the mmdebstrap situation. This will expand $WORKROOT
before passing it to mmdebstrap
--customize-hook="cp foo \"\$1\"/$WORKROOT"…
Yes, but if you do not want to use a caching proxy like apt-cacher-ng, you can also solve this problem by using a hook. If you write a good hook script, I can ship it together with the mmdebstrap…
convert()
: add option to get engine document (e.g. pikepdf.Pdf)
Please do not change the signature of the convert() function. This is necessary to preserve API stability. You have to extract "outputstream" from kwargs.
convert()
: add option to get engine document (e.g. pikepdf.Pdf)
You split tostream()
into finalize()
and tostream()
but then why does the new tostream()
not call finalize()
?
convert()
: add option to get engine document (e.g. pikepdf.Pdf)
Thank you for your work and for your patience with me. I'm going to be on a business trip next week (I'm switching jobs end of september/beginning of october) so my next feedback might take a while but please feel free to ping me if you like.
It makes the code harder to read, yes. But the advantage is, that this way, recent versions of img2pdf keep working on older platforms and distributions that ship Pillow before version 6 are still…
I updated the code to
getattr(...)
as drafted above. It's a one-liner now.
Thank you! Could you squash both commits into one?