josch commented on pull request josch/img2pdf#200 2024-08-27 08:22:36 +00:00
Extract an API to predict the DPI used by img2pdf (with Pillow)

This change looks okay. Did you run the testsuite for your pull requests?

josch commented on pull request josch/img2pdf#201 2024-08-27 08:17:19 +00:00
Slightly simplify imgformat retrieval

No need for a loop here - we can access the enum like a dictionary.

Yes, if your python version is recent enough. Is there an objective reason to change this?

josch commented on pull request josch/img2pdf#202 2024-08-27 08:13:34 +00:00
Slightly simplify the getexif procedure

checks like these for _getexif are there for a reason. Could you try and find out what changed that does not make these necessary anymore and since when it is like that?

josch commented on pull request josch/img2pdf#203 2024-08-27 08:10:49 +00:00
convert(): add option to get engine document (e.g. pikepdf.Pdf)

I'm not happy with the design of adding another function argument which then, if set, changes the output type of the function. I think a better pattern would be to factor out the relevant code…

josch commented on issue josch/mmdebstrap#43 2024-08-21 08:46:36 +00:00
networking problems with generated live systems

I think you should look into what systemd scripts do differently depending on whether they are executed in fakechroot versus in an unshared user namespace chroot. Systemd scripts will check…

josch commented on issue josch/plakativ#9 2024-08-07 05:43:43 +00:00
Windows artifacts not available

Thank you! The issue should now be fixed with e415d0202a2e7371e57e86a36903cbe8c1bff186

josch pushed to main at josch/plakativ 2024-08-07 05:42:30 +00:00
e415d0202a README.md: stop referencing appveyor for installation
josch commented on issue josch/plakativ#9 2024-08-06 15:02:33 +00:00
Windows artifacts not available

Yes, this was the case in the past but hasn't been for nearly a year now. Where did you find that text?

josch commented on issue josch/plakativ#9 2024-08-06 09:54:16 +00:00
Windows artifacts not available
josch commented on issue josch/img2pdf#199 2024-07-16 21:14:52 +00:00
feature request: compress image losslessly within pdf

I still do not understand this part. I have expected to see one image being compressed and another just being directly embedded.

The PDF format allows for images to be encoded using the Paeth…

josch commented on issue josch/img2pdf#199 2024-07-16 17:27:43 +00:00
feature request: compress image losslessly within pdf

I have tried converting the same non-transparent PNG image, which was saved as interlaced and not interlaced, and in both cases it was zlib compressed.

Of course, that's how the PNG format…

josch commented on issue josch/img2pdf#199 2024-07-16 06:10:00 +00:00
feature request: compress image losslessly within pdf

Do I understand correctly that img2pdf currently compresses almost all image types (png, tiff etc.) and only jpegs are left uncompressed? README file suggest the opposite, but Adobe Acrobat…

josch pushed to main at josch/mmdebstrap 2024-07-12 07:59:38 +00:00
98b3c7f2cd m-a-b-q: replace test_installed by dpkg-checkbuilddeps
josch commented on issue josch/img2pdf#199 2024-07-07 12:31:57 +00:00
feature request: compress image losslessly within pdf

Since systemd, everything has become so complicated for me that I can't understand it anymore

You are not alone. In the #debian-devel IRC channel it happens quite a few times that nobody…

josch commented on issue josch/img2pdf#199 2024-07-07 11:33:32 +00:00
feature request: compress image losslessly within pdf

I feared you would suggest that. But would yet another command line option be a good interface? I'd argue that --gzip is too general of an option as that could mean anything and maybe is needed…

josch commented on issue josch/img2pdf#199 2024-07-07 10:56:42 +00:00
feature request: compress image losslessly within pdf

Thank you, I now found the solution to this problem. The jpeg format apparently compresses badly for large areas of equal color. Steps to reproduce:

$ convert -size 8000x8000 xc:white…
josch commented on issue josch/img2pdf#199 2024-07-07 07:37:33 +00:00
feature request: compress image losslessly within pdf

The gitlab@mister-muffin.de address is the one that you can use to talk to this instance of gitea. It used to be a gitlab instance and hence the name. But my personal email is a different one. My…

josch commented on issue josch/img2pdf#199 2024-07-07 06:54:14 +00:00
feature request: compress image losslessly within pdf

But... who is gitlab@mister-muffin.de?

josch commented on issue josch/img2pdf#199 2024-07-07 05:38:56 +00:00
feature request: compress image losslessly within pdf

I have already sent you the PDF file of my examples by email.

I fail to find that mail in my inbox. What subject or message id was that?

josch commented on issue josch/img2pdf#199 2024-07-06 06:48:12 +00:00
feature request: compress image losslessly within pdf

Perhaps the deflating method from ocrmypdf can also be used for img2jpg

The irony: ocrmypdf depends on img2pdf for its functionality ;)

How ocrmypdf does it? Like this:

<<…