Patrick McCarty phmccarty
  • Joined on
Loading Heatmap…

phmccarty commented on issue josch/img2pdf#181

Incorrect page size with different resolutions in x and y directions

Thanks! Confirmed working now :)

6 months ago

phmccarty commented on issue josch/img2pdf#181

Incorrect page size with different resolutions in x and y directions

@josch Testing with the latest commit with a PNG that *does* have a DPI set, img2pdf changes the DPI to 96x96. PIL sets the `dpi` field instead of `aspect` in that case. Shouldn't img2pdf keep…

6 months ago

phmccarty commented on issue josch/img2pdf#181

Incorrect page size with different resolutions in x and y directions

> This is all part of a python rewrite of gscan2pdf. I'm using img2pdf to create the PDFs before using OCRmyPDF to add the text layer. > > I'm manipulating the images internally with PIL, and…

6 months ago

phmccarty commented on issue josch/img2pdf#181

Incorrect page size with different resolutions in x and y directions

I'm not sure what the root cause might be, but I found a workaround: Use the `-units` flag when creating the images. For example: ``` convert rose: -density 100x200 -units PixelsPerInch…

6 months ago

phmccarty commented on issue josch/img2pdf#155

PDF timestamp handling issue

@josch Yep, that patch works for me, thanks!

12 months ago

phmccarty commented on issue josch/img2pdf#155

PDF timestamp handling issue

> - maybe a package in arch linux also ships /usr/share/color/icc/sRGB.icc and you just have it not installed -- can you check? I discovered that `/usr/share/color/icc/sRGB.icc` is provided by…

12 months ago

phmccarty deleted branch utc-timestamps from phmccarty/img2pdf

12 months ago

phmccarty commented on issue josch/img2pdf#155

PDF timestamp handling issue

> I also added a bunch of test cases for this in b25429a4c11bd62171066e8b9caf1b80c610ee58 so that this problem doesn't happen again. > > Could you try running `pytest` with the latest git HEAD…

12 months ago

phmccarty commented on pull request josch/img2pdf#168

Convert creation/modification dates to UTC (fixes #155)

One more update: I squashed changes into one commit to minimize the churn between commits.

12 months ago

phmccarty pushed to utc-timestamps at phmccarty/img2pdf

  • 81502f21af Convert creation/modification dates to UTC (fixes #155)
  • 0cbcb8fa12 avoid converting palette PNG with alpha to RGB (closes: #158)
  • e9e04b6dd9 extend comments around dropping ICC profile stored by GIMP for bilevel input
  • fc059ee471 use quotes around caret in examples for windows users
  • 25466113e9 another small fixup for the last commit
  • Compare 7 commits »

12 months ago

phmccarty pushed to utc-timestamps at phmccarty/img2pdf

  • 512478ac4e Fix format of PDF and XMP timezone offsets

12 months ago

phmccarty commented on pull request josch/img2pdf#168

Convert creation/modification dates to UTC (fixes #155)

Updated the MR to reflect the discussion from #155

12 months ago

phmccarty pushed to utc-timestamps at phmccarty/img2pdf

12 months ago

phmccarty commented on issue josch/img2pdf#155

PDF timestamp handling issue

Thanks for the hint about `astimezone()` method, by the way; I had somehow missed it while researching for a solution to this issue... > Would it not be easier to just store the timestamp in…

12 months ago

phmccarty commented on issue josch/img2pdf#155

PDF timestamp handling issue

> Can you confirm? Your patch works for the default case, but it does not work when specifying `--creationdate` and/or `--moddate` strings that have non-UTC timezones. The output of my…

12 months ago

phmccarty commented on issue josch/img2pdf#155

PDF timestamp handling issue

> Sorry for that. There are hundreds of bots per month creating multiple accounts and spamming my gitea installation with several repos, issues and comments to post their spam per day. I have an…

1 year ago

phmccarty pushed to pdf-xmp-timestamps at phmccarty/img2pdf

  • 5100507403 Address discrepancies between PDF and XMP timestamps

1 year ago

phmccarty pushed to pdf-xmp-timestamps at phmccarty/img2pdf

  • ee5adf90f5 Address discrepancies between PDF and XMP timestamps

1 year ago

phmccarty commented on pull request josch/img2pdf#168

Convert creation/modification dates to UTC (fixes #155)

After doing a bit more research, I discovered that PDF and XMP have different syntax for timezone offsets... I pushed an experimental change to another branch (atop this branch): https://gitlab.mis…

1 year ago

phmccarty created branch pdf-xmp-timestamps in phmccarty/img2pdf

1 year ago