Patrick McCarty phmccarty
  • Joined on 2023-05-29
phmccarty approved josch/img2pdf#184 2024-11-05 01:53:09 +00:00
Add support for JBIG2 (generic coding)

Changes look good to me

phmccarty commented on pull request josch/img2pdf#184 2024-11-05 01:48:53 +00:00
Add support for JBIG2 (generic coding)

Okay, that makes sense then. No objection from me.

phmccarty commented on pull request josch/img2pdf#184 2024-11-01 18:53:01 +00:00
Add support for JBIG2 (generic coding)

One question about the style of the code here:

phmccarty commented on pull request josch/img2pdf#184 2024-10-30 17:02:30 +00:00
Add support for JBIG2 (generic coding)

@ooBJ3u Thanks! I re-tested with your latest commit, and I no longer see that syntax error.

phmccarty commented on pull request josch/img2pdf#184 2024-10-11 00:33:49 +00:00
Add support for JBIG2 (generic coding)

That could explain it. Do you happen to have the byte strings that should be removed at the end handy? We can check to make sure those are present, and then remove those in that case.

Sure,…

phmccarty commented on pull request josch/img2pdf#184 2024-10-10 23:05:20 +00:00
Add support for JBIG2 (generic coding)

@phmccarty that sounds like a bug in pdfimages. I've created and distributed many files with this MR, and they all open properly in PDF readers, and haven't heard any issues from users with…

phmccarty commented on pull request josch/img2pdf#184 2024-10-10 20:54:51 +00:00
Add support for JBIG2 (generic coding)

FWIW, I tested the changes in this MR by converting some TIFF files to JBIG2 (with jbig2 file.tif > file.jb2) and running img2pdf on them, and the resulting PDF seems to work just fine.

Howeve…

phmccarty commented on issue josch/img2pdf#181 2023-11-25 20:54:06 +00:00
Incorrect page size with different resolutions in x and y directions

Thanks! Confirmed working now :)

phmccarty commented on issue josch/img2pdf#181 2023-11-25 18:56:38 +00:00
Incorrect page size with different resolutions in x and y directions

@josch Testing with the latest commit with a PNG that does have a DPI set, img2pdf changes the DPI to 96x96. PIL sets the dpi field instead of aspect in that case.

Shouldn't img2pdf keep…

phmccarty commented on issue josch/img2pdf#181 2023-11-17 19:58:34 +00:00
Incorrect page size with different resolutions in x and y directions

This is all part of a python rewrite of gscan2pdf. I'm using img2pdf to create the PDFs before using OCRmyPDF to add the text layer.

I'm manipulating the images internally with PIL, and…

phmccarty commented on issue josch/img2pdf#181 2023-11-16 23:37:48 +00:00
Incorrect page size with different resolutions in x and y directions

I'm not sure what the root cause might be, but I found a workaround: Use the -units flag when creating the images. For example:

convert rose: -density 100x200 -units PixelsPerInch…
phmccarty commented on issue josch/img2pdf#155 2023-06-11 16:10:07 +00:00
PDF timestamp handling issue

@josch Yep, that patch works for me, thanks!

phmccarty commented on issue josch/img2pdf#155 2023-06-11 15:20:35 +00:00
PDF timestamp handling issue
  • maybe a package in arch linux also ships /usr/share/color/icc/sRGB.icc and you just have it not installed -- can you check?

I discovered that /usr/share/color/icc/sRGB.icc is provided by…

phmccarty deleted branch utc-timestamps from phmccarty/img2pdf 2023-06-11 07:14:48 +00:00
phmccarty commented on issue josch/img2pdf#155 2023-06-11 07:13:49 +00:00
PDF timestamp handling issue

I also added a bunch of test cases for this in b25429a4c11bd62171066e8b9caf1b80c610ee58 so that this problem doesn't happen again.

Could you try running pytest with the latest git HEAD…

phmccarty commented on pull request josch/img2pdf#168 2023-06-11 01:05:17 +00:00
Convert creation/modification dates to UTC (fixes #155)

One more update: I squashed changes into one commit to minimize the churn between commits.

phmccarty pushed to utc-timestamps at phmccarty/img2pdf 2023-06-11 01:01:49 +00:00
81502f21af Convert creation/modification dates to UTC (fixes #155)
0cbcb8fa12 avoid converting palette PNG with alpha to RGB (closes: #158)
e9e04b6dd9 extend comments around dropping ICC profile stored by GIMP for bilevel input
fc059ee471 use quotes around caret in examples for windows users
25466113e9 another small fixup for the last commit
Compare 7 commits »
phmccarty pushed to utc-timestamps at phmccarty/img2pdf 2023-06-11 00:37:01 +00:00
512478ac4e Fix format of PDF and XMP timezone offsets
phmccarty commented on pull request josch/img2pdf#168 2023-06-11 00:35:51 +00:00
Convert creation/modification dates to UTC (fixes #155)

Updated the MR to reflect the discussion from #155

phmccarty pushed to utc-timestamps at phmccarty/img2pdf 2023-06-11 00:35:13 +00:00
85efd9a80a Fix format of PDF and XMP timezone offsets
9c3753ed2b Convert manual creation/mod times to UTC as well
Compare 2 commits »