• Joined on

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

Hi @josch. It's been a while since I last used the package. I'll try to look into it.

1 year ago

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

> Luckily, I'm the Debian maintainer of img2pdf so I can adjust things there as needed. Well if you can make Debian switch to IM7, that'd be cool :) I just don't realise how much work that…

2 years ago

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

I meant all the commits from https://gitlab.mister-muffin.de/josch/img2pdf/pulls/117 Those made the tests work with both IM6 and IM7. I am surprised that tests fail on Travis but I am pretty sure…

2 years ago

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

@josch I do have IM7 and with the commits I pushed to main, the tests pass fine. Are you seeing additional failures?

2 years ago

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

@josch I don't know if you followed the issue I opened but it sounds like you should indeed stop testing the value of `depth`.

3 years ago

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

> I'm a Debian Developer and can help the packaging effort and offered my help in the relevant bug report Good to know, in that case maybe the next Ubuntu version will have IM 7 at least. I…

3 years ago

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

Well tests fail with Python 3.5 because of a str/bytes thing so I guess the minimum version will be Focal with 3.6.

3 years ago

sbraz commented on issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

I can confirm that the `depth` attribute contains the compile-time constant quantum depth for TIFF images whereas `baseDepth` contains the actual depth (but for PNG or JPG, both attributes contain…

3 years ago

sbraz opened issue josch/img2pdf#120

Tests fail with ImageMagick compiled with --with-quantum-depth=8 or 32

3 years ago

sbraz commented on issue josch/img2pdf#119

test_tiff_rgb12 and test_tiff_rgb14 fail with ImageMagick 6.9.10

> Are you saying that Ubuntu Focal also needs the value 16? What value is needed for ImageMagick 7? Yes, I think so. Throughout my tests, I saw that all versions (Gentoo or Arch with IM 7, Focal…

3 years ago

sbraz opened issue josch/img2pdf#119

test_tiff_rgb12 and test_tiff_rgb14 fails with ImageMagick 6.9.10

3 years ago

sbraz created pull request josch/img2pdf#118

Remove ineffective description-file parameter from setup.cfg

3 years ago

sbraz pushed to description at sbraz/img2pdf

  • d03f331521 Remove ineffective description-file parameter from setup.cfg

3 years ago

sbraz created branch description in sbraz/img2pdf

3 years ago

sbraz commented on pull request josch/img2pdf#117

Make tests work with ImageMagick 6 and 7, fixes #111

Thanks! I tested commit 55d589a548cd881c3fe5a94a1c7e2db6a88ae8ea with Ubuntu 20 to match what Travis does and it fails the ICC tests (and TIFF tests) there too so the problem isn't linked to this PR…

3 years ago

sbraz commented on pull request josch/img2pdf#117

Make tests work with ImageMagick 6 and 7, fixes #111

Oh right 🙂 In that case, yes, tests do pass, no skips or anything else. Here is the output from that Dockerfile, if you want to test yourself: ```Dockerfile FROM debian:bullseye RUN apt…

3 years ago

sbraz commented on pull request josch/img2pdf#117

Make tests work with ImageMagick 6 and 7, fixes #111

Tests are passing but `compare`, the function that relied on `icc-profiles-free` is never called with `icc=True` so that part of the code is never tested. If you could add a test that uses it to…

3 years ago

sbraz pushed to im7 at sbraz/img2pdf

3 years ago

sbraz pushed to im7 at sbraz/img2pdf

3 years ago