Hi @josch. It's been a while since I last used the package. I'll try to look into it.
Luckily, I'm the Debian maintainer of img2pdf so I can adjust things there as needed.
Well if you can make Debian switch to IM7, that'd be cool :) I just don't realise how much work that…
I meant all the commits from josch/img2pdf#117
Those made the tests work with both IM6 and IM7. I am surprised that tests fail on Travis but I am pretty sure…
@josch I do have IM7 and with the commits I pushed to main, the tests pass fine. Are you seeing additional failures?
@josch I don't know if you followed the issue I opened but it sounds like you should indeed stop testing the value of depth.
I'm a Debian Developer and can help the packaging effort and offered my help in the relevant bug report
Good to know, in that case maybe the next Ubuntu version will have IM 7 at least.
I…
Well tests fail with Python 3.5 because of a str/bytes thing so I guess the minimum version will be Focal with 3.6.
I can confirm that the depth attribute contains the compile-time constant quantum depth for TIFF images whereas baseDepth contains the actual depth (but for PNG or JPG, both attributes contain…
Are you saying that Ubuntu Focal also needs the value 16? What value is needed for ImageMagick 7?
Yes, I think so. Throughout my tests, I saw that all versions (Gentoo or Arch with IM 7, Focal…
Thanks! I tested commit 55d589a548cd881c3fe5a94a1c7e2db6a88ae8ea with Ubuntu 20 to match what Travis does and it fails the ICC tests (and TIFF tests) there too so the problem isn't linked to this PR…
Oh right 🙂 In that case, yes, tests do pass, no skips or anything else.
Here is the output from that Dockerfile, if you want to test yourself:
FROM debian:bullseye
RUN apt…Tests are passing but compare, the function that relied on icc-profiles-free is never called with icc=True so that part of the code is never tested.
If you could add a test that uses it to…