I re-ran the tests on current Rawhide and now the jpeg are succeeding, i.e. it just remains:
========================== short test summary info ============================
FAILED…FWIW, a few years ago I excluded img2pdf from s390x builds.
For years nobody from the Fedora/Redhat s390x team looked into any reported ImageMagick issues.
I think it's fair to say that…
I think that this issue can be closed. I don't see these issues in later versions on Fedora, anymore.
AFAICS, all the old test case failures are now gone
@gms could you close those issues that do not apply to Fedora anymore? Thanks!
Sure, I've checked my notes and the old ones that…
Hrm... odd that it doesn't work for you then.
It should work. It's just that I wasn't aware of this change and I thus hadn't modified the build dependencies. Thus, all the builds until now…
The ImageMagick verison isn't much newer on Rawhide and yields the same results AFAICS:
$ rpm -q ImageMagick
ImageMagick-7.1.1.13-2.fc39.x86_64
$ convert --version Could you run this command on some true-color and have a look in the output what the new name of the key is that has the "TrueColor" value?
Sure, this is from a Fedora 38 system:
$…Ok, I've did a scratch build on aarch64 with the current main branch and that patch on top:
https://kojipkgs.fedoraproject.org//work/tasks/3250/103743250/build.log
AFAICS, the endian errors…
Hm, the patch doesn't apply on top of 0.4.4.
Sorry, it took me some time to get back to this.
Unfortunately, debian pastebin has already removed the patch, it seems.
Can you post it again, e.g. perhaps attach it to this issue?
Okay, but the commit I referenced above is sufficient to fix this issue right now, correct?
No, unfortunately, it's not.
Currently, I'm working around it in the Fedora rawhide builds like…
I'm afraid the endianess issue is more involved than it seems and thus the s390x fix isn't sufficient:
https://github.com/ImageMagick/ImageMagick/issues/6300
tl;dr: IM7 currently creates…
Ok, I added the following patch to fix the ValueError:
--- a/src/img2pdf_test.py 2023-01-22 18:36:32.208977359 +0100
+++ b/src/img2pdf_test.py 2023-01-22 18:39:52.918531386 +0100
@@…ImageMagick version: ImageMagick 1:7.1.0.57-1.fc38
Img2pdf version: 0.4.4