josch/mmdebstrap
2
3
Fork 6
Code Issues 8 Pull requests 1 Projects Releases Wiki Activity

gpg: handle ASCII-armored keyrings as well #1

Closed
rockdrilla wants to merge 1 commit from rockdrilla:gpg-handle-ascii-keyrings into main
pull from: rockdrilla:gpg-handle-ascii-keyrings
merge into: josch:main
Conversation 8 Commits 1 Files changed -
rockdrilla commented 2021-04-25 19:40:50 +00:00
Contributor
Copy link

gpg command "--list-keys" requires input files to be passed with
option "--keyring" and each file must match type "public keyring v4"
while gpg command "--show-keys" doesn't require extra options and
handles also ASCII-armored public keyrings as well.

Signed-off-by: Konstantin Demin rockdrilla@gmail.com

gpg command "--list-keys" requires input files to be passed with option "--keyring" and each file must match type "public keyring v4" while gpg command "--show-keys" doesn't require extra options and handles also ASCII-armored public keyrings as well. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added 1 commit 2021-04-25 19:40:51 +00:00 
gpg command "--list-keys" requires input files to be passed with
option "--keyring" and each file must match type "public keyring v4"
while gpg command "--show-keys" doesn't require extra options and
handles also ASCII-armored public keyrings as well.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
josch commented 2021-04-25 20:05:01 +00:00
Owner
Copy link

Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D

I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests?

Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests?
rockdrilla commented 2021-04-25 20:16:49 +00:00
Author
Contributor
Copy link

Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D

I'm happy too! xD

I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests?

Test suite was broken some time ago, but I've fixed that issue (I hope so): I've added some checks against empty files which was pain for gnupg and also I've muted gnupg warning about "trustness" just initializing empty trustdb.

Nevertheless, I'm going to put script to run all night long to test that everything is ok.

> Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D I'm happy too! xD > I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests? Test suite was broken some time ago, but I've fixed that issue (I hope so): I've added some checks against empty files which was pain for gnupg and also I've muted gnupg warning about "trustness" just initializing empty trustdb. Nevertheless, I'm going to put script to run all night long to test that everything is ok.
rockdrilla commented 2021-04-27 08:54:51 +00:00
Author
Contributor
Copy link

Tests are failing on other point: (169/193) mode=proot,variant=debootstrap: create tarball.
Command: ./make_mirror.sh ; ONLINE=yes CMD=./mmdebstrap ./coverage.sh

I think this is due to heavy load with qemu/kvm.
I also have "amdgpu" wailing in dmesg. 😂

Tests are failing on other point: (169/193) mode=proot,variant=debootstrap: create tarball. Command: ./make_mirror.sh ; ONLINE=yes CMD=./mmdebstrap ./coverage.sh I think this is due to heavy load with qemu/kvm. I also have "amdgpu" wailing in dmesg. 😂
josch commented 2021-04-27 09:07:06 +00:00
Owner
Copy link

Try running:

./make_mirror.sh
HAVE_PROOT=no CMD=./mmdebstrap ./coverage.sh

proot support is kinda borked these days...

Try running: ./make_mirror.sh HAVE_PROOT=no CMD=./mmdebstrap ./coverage.sh proot support is kinda borked these days...
rockdrilla commented 2021-04-27 19:08:46 +00:00
Author
Contributor
Copy link

Test suite required a lot of resources, so I can't launch it on my vps for all night long. I also can't launch it on my laptop because it loads my system hard.

Test suite required a lot of resources, so I can't launch it on my vps for all night long. I also can't launch it on my laptop because it loads my system hard.
josch commented 2021-05-04 17:10:19 +00:00
Owner
Copy link

Did you change something compared to your last pull request? The test suite passes successfully now. I can merge it now.

Did you change something compared to your last pull request? The test suite passes successfully now. I can merge it now.
rockdrilla commented 2021-05-04 18:34:17 +00:00
Author
Contributor
Copy link

Did you change something compared to your last pull request? The test suite passes successfully now.

Of course. :)

> Did you change something compared to your last pull request? The test suite passes successfully now. Of course. :)
josch added 1 commit 2021-05-07 09:17:19 +00:00
josch commented 2021-05-07 09:17:46 +00:00
Owner
Copy link

fixed by ccd4b5c163

fixed by ccd4b5c163d322045c92f734f43bb5e1945fa774
josch closed this pull request 2021-05-07 09:17:52 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: josch/mmdebstrap#1
No description provided.
Delete branch "rockdrilla:gpg-handle-ascii-keyrings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?