gpg: handle ASCII-armored keyrings as well #1

Closed
rockdrilla wants to merge 1 commits from rockdrilla:gpg-handle-ascii-keyrings into main

gpg command "--list-keys" requires input files to be passed with
option "--keyring" and each file must match type "public keyring v4"
while gpg command "--show-keys" doesn't require extra options and
handles also ASCII-armored public keyrings as well.

Signed-off-by: Konstantin Demin rockdrilla@gmail.com

gpg command "--list-keys" requires input files to be passed with option "--keyring" and each file must match type "public keyring v4" while gpg command "--show-keys" doesn't require extra options and handles also ASCII-armored public keyrings as well. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added 1 commit 3 years ago
ccd4b5c163
gpg: handle ASCII-armored keyrings as well
gpg command "--list-keys" requires input files to be passed with
option "--keyring" and each file must match type "public keyring v4"
while gpg command "--show-keys" doesn't require extra options and
handles also ASCII-armored public keyrings as well.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
josch commented 3 years ago
Owner

Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D

I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests?

Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests?
Poster

Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D

I'm happy too! xD

I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests?

Test suite was broken some time ago, but I've fixed that issue (I hope so): I've added some checks against empty files which was pain for gnupg and also I've muted gnupg warning about "trustness" just initializing empty trustdb.

Nevertheless, I'm going to put script to run all night long to test that everything is ok.

> Hi, you are the first to use my new self hosted code hosting platform using gitea instead of gitlab (which was a pain to maintain). I hope that nothing breaks as I'm still in the early stages of trying out this platform. Apparently stuff like user registration, pull requests and email notifiations seem to work just fine! :D I'm happy too! xD > I'm also happy that you are persistent with getting your improvements merged. Unfortunately your changes break the test suite. Did you run the tests? Test suite was broken some time ago, but I've fixed that issue (I hope so): I've added some checks against empty files which was pain for gnupg and also I've muted gnupg warning about "trustness" just initializing empty trustdb. Nevertheless, I'm going to put script to run all night long to test that everything is ok.
Poster

Tests are failing on other point: (169/193) mode=proot,variant=debootstrap: create tarball.
Command: ./make_mirror.sh ; ONLINE=yes CMD=./mmdebstrap ./coverage.sh

I think this is due to heavy load with qemu/kvm.
I also have "amdgpu" wailing in dmesg. 😂

Tests are failing on other point: (169/193) mode=proot,variant=debootstrap: create tarball. Command: ./make_mirror.sh ; ONLINE=yes CMD=./mmdebstrap ./coverage.sh I think this is due to heavy load with qemu/kvm. I also have "amdgpu" wailing in dmesg. 😂
josch commented 3 years ago
Owner

Try running:

./make_mirror.sh
HAVE_PROOT=no CMD=./mmdebstrap ./coverage.sh

proot support is kinda borked these days...

Try running: ./make_mirror.sh HAVE_PROOT=no CMD=./mmdebstrap ./coverage.sh proot support is kinda borked these days...
Poster

Test suite required a lot of resources, so I can't launch it on my vps for all night long. I also can't launch it on my laptop because it loads my system hard.

Test suite required a lot of resources, so I can't launch it on my vps for all night long. I also can't launch it on my laptop because it loads my system hard.
josch commented 3 years ago
Owner

Did you change something compared to your last pull request? The test suite passes successfully now. I can merge it now.

Did you change something compared to your last pull request? The test suite passes successfully now. I can merge it now.
Poster

Did you change something compared to your last pull request? The test suite passes successfully now.

Of course. :)

> Did you change something compared to your last pull request? The test suite passes successfully now. Of course. :)
josch added 1 commit 3 years ago
josch commented 3 years ago
Owner

fixed by ccd4b5c163

fixed by ccd4b5c163d322045c92f734f43bb5e1945fa774
josch closed this pull request 3 years ago
This pull request cannot be reopened because the branch was deleted.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b rockdrilla-gpg-handle-ascii-keyrings main
git pull gpg-handle-ascii-keyrings

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff rockdrilla-gpg-handle-ascii-keyrings
git push origin main
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: josch/mmdebstrap#1
Loading…
There is no content yet.