josch commented on issue josch/img2pdf#119 2021-08-22 17:40:46 +00:00
test_tiff_rgb12 and test_tiff_rgb14 fail with ImageMagick 6.9.10

Are you saying that Ubuntu Focal also needs the value 16? What value is needed for ImageMagick 7?

Yes, I think so. Throughout my tests, I saw that all versions (Gentoo or Arch with IM 7,…

josch commented on issue josch/img2pdf#119 2021-08-22 17:16:13 +00:00
test_tiff_rgb12 and test_tiff_rgb14 fail with ImageMagick 6.9.10

Thanks for looking into this! But I don't think I follow. I can confirm that on Debian Bullseye, the else clause is the right one, the one which says:

assert…
josch commented on pull request josch/img2pdf#106 2021-08-22 08:44:40 +00:00
Convert 8-bit PNG & GIF alpha channels to /SMasks in PDF

However, I'm encountering an issue where some TIFF test cases are checking the depth field reported by ImageMagick differently, depending on its version. Namely, this one:

    if…
josch pushed to main at josch/img2pdf 2021-08-22 08:08:37 +00:00
f483638b17 Test cases for transparency
7f216a8848 Test support on macOS
2476215f39 Always initialize smask
f62858c245 Formatting
a5e4da5755 Use PNG predictor for /SMask too
Compare 7 commits »
josch merged pull request josch/img2pdf#106 2021-08-22 08:08:31 +00:00
Convert 8-bit PNG & GIF alpha channels to /SMasks in PDF
josch merged pull request josch/img2pdf#118 2021-08-22 07:32:54 +00:00
Remove ineffective description-file parameter from setup.cfg
josch pushed to main at josch/img2pdf 2021-08-22 07:32:37 +00:00
d03f331521 Remove ineffective description-file parameter from setup.cfg
josch commented on pull request josch/img2pdf#118 2021-08-22 07:32:06 +00:00
Remove ineffective description-file parameter from setup.cfg

Thank you! 😃

josch commented on pull request josch/img2pdf#117 2021-08-21 21:07:14 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

Since the tests pass for you, I have merged this. But the test_png_icc tests keep failing: https://travis-ci.com/github/josch/img2pdf

josch closed issue josch/img2pdf#111 2021-08-21 20:54:17 +00:00
Tests fail with ImageMagick 7
josch merged pull request josch/img2pdf#117 2021-08-21 20:53:52 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111
josch pushed to main at josch/img2pdf 2021-08-21 20:53:45 +00:00
635b08c321 README: fix CI URLs
152f6fb629 tests: look for sRGB.icc in several paths, skip related tests if not found
1f3b456ac9 tests: don't expect ImageMagick to compress TIFF files by default
Compare 3 commits »
josch commented on pull request josch/img2pdf#117 2021-08-21 20:30:05 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

Tests are passing but compare, the function that relied on icc-profiles-free is never called with icc=True so that part of the code is never tested.

If you could add a test that uses…

josch commented on pull request josch/img2pdf#117 2021-08-21 05:34:36 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

Are the tests really passing for you? Or are they just skipped?

For example I don't know how you can just remove installing icc-profiles-free because those profiles are needed for tests like…

josch commented on pull request josch/img2pdf#117 2021-08-19 11:22:06 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

Thanks, I'll look into possible paths for it. Did you see my other question?

Do you need different ICC profiles (the one from icc-profiles and the one from Ghostscript) or can we use the same…

josch commented on pull request josch/img2pdf#106 2021-08-19 11:20:19 +00:00
Convert 8-bit PNG & GIF alpha channels to /SMasks in PDF

Hi,

could you rebase your commits on top of the current main branch? I merged some of the other merge requests which should fix compatibility with imagemagick 7 that you are running.

Would you…

josch commented on pull request josch/img2pdf#117 2021-08-19 11:13:53 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

I just merged #109 and #110.

If you know under which paths srgb.icc is stored for different distros, then yes, it makes sense to try those and skip if nothing can be found.

josch deleted branch tests-skip-profile from paper/img2pdf 2021-08-19 11:11:00 +00:00
josch closed pull request josch/img2pdf#109 2021-08-19 11:10:22 +00:00
src/img2pdf_test.py: skip tests when icc profiles are not present
josch commented on pull request josch/img2pdf#109 2021-08-19 11:10:09 +00:00
src/img2pdf_test.py: skip tests when icc profiles are not present

merged as 4c5b72dab02a7dc9590ab4e760acd3764094fea8