Are you saying that Ubuntu Focal also needs the value 16? What value is needed for ImageMagick 7?
Yes, I think so. Throughout my tests, I saw that all versions (Gentoo or Arch with IM 7,…
Thanks for looking into this! But I don't think I follow. I can confirm that on Debian Bullseye, the else
clause is the right one, the one which says:
assert…
However, I'm encountering an issue where some TIFF test cases are checking the
depth
field reported by ImageMagick differently, depending on its version. Namely, this one:if…
smask
Since the tests pass for you, I have merged this. But the test_png_icc
tests keep failing: https://travis-ci.com/github/josch/img2pdf
Tests are passing but
compare
, the function that relied onicc-profiles-free
is never called withicc=True
so that part of the code is never tested.If you could add a test that uses…
Are the tests really passing for you? Or are they just skipped?
For example I don't know how you can just remove installing icc-profiles-free
because those profiles are needed for tests like…
Thanks, I'll look into possible paths for it. Did you see my other question?
Do you need different ICC profiles (the one from icc-profiles and the one from Ghostscript) or can we use the same…
Hi,
could you rebase your commits on top of the current main branch? I merged some of the other merge requests which should fix compatibility with imagemagick 7 that you are running.
Would you…
I just merged #109 and #110.
If you know under which paths srgb.icc is stored for different distros, then yes, it makes sense to try those and skip if nothing can be found.
merged as 4c5b72dab02a7dc9590ab4e760acd3764094fea8