josch commented on pull request josch/img2pdf#117 2021-08-19 11:13:53 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

I just merged #109 and #110.

If you know under which paths srgb.icc is stored for different distros, then yes, it makes sense to try those and skip if nothing can be found.

josch deleted branch tests-skip-profile from paper/img2pdf 2021-08-19 11:11:00 +00:00
josch closed pull request josch/img2pdf#109 2021-08-19 11:10:22 +00:00
src/img2pdf_test.py: skip tests when icc profiles are not present
josch commented on pull request josch/img2pdf#109 2021-08-19 11:10:09 +00:00
src/img2pdf_test.py: skip tests when icc profiles are not present

merged as 4c5b72dab02a7dc9590ab4e760acd3764094fea8

josch pushed to main at josch/img2pdf 2021-08-19 11:08:53 +00:00
4c5b72dab0 src/img2pdf_test.py: skip tests when icc profiles are not present
josch pushed to tests-skip-profile at paper/img2pdf 2021-08-19 11:02:09 +00:00
cd7043dc84 Merge branch 'main' into tests-skip-profile
853a1ec363 src/img2pdf_test.py: do not test format descriptions
55d589a548 README.md: document how to remove alpha channel and --rotation=ifvalid
5c617965f5 document the ifvalid option value further
0067edf965 remove first_frame_only from gui
Compare 5 commits »
josch merged pull request josch/img2pdf#110 2021-08-19 11:00:13 +00:00
src/img2pdf_test.py: do not test format descriptions
josch pushed to main at josch/img2pdf 2021-08-19 11:00:08 +00:00
853a1ec363 src/img2pdf_test.py: do not test format descriptions
josch pushed to tests-no-description at paper/img2pdf 2021-08-19 10:57:55 +00:00
bb8a2d8b3a Merge branch 'main' into tests-no-description
55d589a548 README.md: document how to remove alpha channel and --rotation=ifvalid
5c617965f5 document the ifvalid option value further
0067edf965 remove first_frame_only from gui
Compare 4 commits »
josch commented on pull request josch/img2pdf#117 2021-08-19 04:35:17 +00:00
Make tests work with ImageMagick 6 and 7, fixes #111

And why should I reject #110 in favor of the changes of this pull request?

I'm also not going to vendor sRGB.icc. I rather either:

  • test different paths
  • let the distributions patch the…
josch commented on issue josch/mmdebstrap#10 2021-08-16 19:00:39 +00:00
ConditionFirstBoot is never triggered

Funnily, the man page referenced from the commit you cite, also explains the uninialized value. I should've RTFM. :D

josch commented on issue josch/mmdebstrap#10 2021-08-16 18:44:13 +00:00
ConditionFirstBoot is never triggered

Ui, nice catch! Thank you for bringing this up! I'll fix this with the next release.

josch commented on issue josch/img2pdf#116 2021-08-14 11:31:42 +00:00
Weird TIFF Error

No, I don't have anything to do with Ubuntu packaging except if you count that Ubuntu regularly pulls packages from Debian where I'm the maintainer. So the [Ubuntu…

josch pushed tag 0.4.1 to josch/img2pdf 2021-08-14 08:27:53 +00:00
josch pushed to main at josch/img2pdf 2021-08-14 08:27:34 +00:00
55d589a548 README.md: document how to remove alpha channel and --rotation=ifvalid
5c617965f5 document the ifvalid option value further
0067edf965 remove first_frame_only from gui
Compare 3 commits »
josch commented on issue josch/img2pdf#116 2021-08-14 08:27:08 +00:00
Weird TIFF Error

Ah indeed, yes, the image that you posted is a JPEG but it is also an MPO file and support for MPO JPEGs was added in d29c596fe79e4bccd986b0f9e045bab3dbab02dd which is part of img2pdf 0.4.1. Details…

josch commented on issue josch/img2pdf#116 2021-08-13 17:29:35 +00:00
Weird TIFF Error

I'm making the same obseravation on my system as @mara0004. I'm not getting the not a TIFF file error but the MPO warning.

If this file also produces the not a TIFF file error on your…

josch commented on issue josch/img2pdf#116 2021-08-13 04:54:20 +00:00
Weird TIFF Error

If it's a scan, then it should not be related to your phone, no?

You could ask the person from whom you got the scan to scan an empty page for you.

Maybe you can also find out which scanner…

josch commented on issue josch/img2pdf#116 2021-08-12 17:44:56 +00:00
Weird TIFF Error

It is of course completely understandable if you cannot share a private photo.

Unfortunately, there is also nothing I can do without a file that shows the problem you are facing.

Maybe you can…

josch commented on issue josch/img2pdf#116 2021-08-12 08:04:50 +00:00
Weird TIFF Error

Hi, can you narrow this down to the one specific file in your folder that triggers this problem? Once you have the file, you can post it here and I can have a look at it and tell you why img2pdf…