This is how Python prints the bytearray by default, so I figured that is fine.
Great news!
@josch this PR should now really-really be ready to merge then, when you have a moment. 🙏
Apologies again for the delay.
@phmccarty I fixed your issue in 244600065d — see the commit message for more…
That could explain it. Do you happen to have the byte strings that should be removed at the end handy? We can check to make sure those are present, and then remove those in that case.
@phmccarty that sounds like a bug in pdfimages. I've created and distributed many files with this MR, and they all open properly in PDF readers, and haven't heard any issues from users with…
There are a lot of FOSS projects I'm taking are of and unfortunately, I haven't spent as much time on img2pdf recently as I should've.
@josch I know just what you mean, which is why this also…
@josch is this still blocked on anything? Anything I can do to get it merged?
@josch I have a question. Why does this happen:
$ jbigtopnm mono.jb2 jbigtopnm: Invalid contents of input file. Input data stream contains invalid data
Apologies…
@josch Would you like to have another look at this? All comments should be addressed now.
Apologies for the delay. I've updated the README to consistently say "1-bit monochrome" (to differentiate it from the other meaning of "grayscale"). Does this look good?
Monochrome is also often used for greyscale images, however. See e.g. https://en.wikipedia.org/wiki/Monochrome
Bi-level is pretty standard terminology, though "binary images" or perhaps even…
I wasn't sure why this was if instead of elif. Won't that make it so JPEG2000 still crashes? I fixed it but wanted to double-check.
